Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for enums to
HybridObject
:When declaring custom enums there's two steps you need to do:
TestEnum.h
)enum TestEnum { FIRST, SECOND, THIRD };
EnumMapper
by editingcpp/jsi/EnumMapper.h
:This way compile-time safety is guaranteed.
All other approaches to parse enums from C++ to JS are not compile-time but rather run-time, so currently there's no way around editing
EnumMapper.h
unless we do runtime type checking.