eslint/prettier rig & fixes for example app, fixed some tests

eslint.config.mjs

@@ -35,6 +35,6 @@ export default typescriptEslint.config(
   },
   // don't lint config files or example app (in this run)
   {
-    ignores: ['.prettierrc.js', '*.config.js', '**/lib/**', '**/test/**', 'example/**'],
+    ignores: ['*.config.mjs', '*.config.js', '**/lib/**', '**/test/**', 'example/**'],
   },
 );

example/eslint.config.mjs

@@ -0,0 +1,33 @@
+import { fixupPluginRules } from '@eslint/compat';
+import js from '@eslint/js';
+import eslintReactNative from 'eslint-plugin-react-native';
+import typescriptEslint from 'typescript-eslint';
+
+export default typescriptEslint.config(
+  // don't lint config files
+  {
+    ignores: ['*.config.*js'],
+  },
+  {
+    plugins: {
+      '@typescript-eslint': typescriptEslint.plugin,
+    },
+    rules: {},
+  },
+  js.configs.recommended,
+  ...typescriptEslint.configs.recommended,
+  // react-native
+  {
+    name: 'eslint-plugin-react-native',
+    plugins: {
+      'react-native': fixupPluginRules({
+        rules: eslintReactNative.rules,
+      }),
+    },
+    rules: {
+      ...eslintReactNative.configs.all.rules,
+      'react-native/sort-styles': 'off',
+      'react-native/no-inline-styles': 'warn',
+    },
+  },
+);

example/index.js

@@ -1,12 +1,12 @@
+import { AppRegistry } from 'react-native';
+import App from './src/App';
+import { name as appName } from './app.json';
 import { install } from 'react-native-quick-crypto';
 
+const global = globalThis;
 install();
 global.process.cwd = () => 'sxsx';
 global.process.env = { NODE_ENV: 'production' };
 global.location = {};
 
-import { AppRegistry } from 'react-native';
-import App from './src/App';
-import { name as appName } from './app.json';
-
 AppRegistry.registerComponent(appName, () => App);

example/package.json

@@ -6,7 +6,7 @@
   "packageManager": "[email protected]",
   "scripts": {
     "android": "react-native run-android",
-    "ios": "react-native run-ios --simulator='iPhone 15'",
+    "ios": "react-native run-ios",
     "tsc": "tsc --noEmit",
     "typescript": "tsc --noEmit",
     "lint": "eslint \"**/*.{js,ts,tsx}\"",
@@ -41,9 +41,10 @@
     "@babel/plugin-transform-class-static-block": "^7.24.7",
     "@babel/preset-env": "^7.20.0",
     "@babel/runtime": "^7.20.0",
+    "@eslint/compat": "^1.1.1",
+    "@eslint/js": "10.0.0",
     "@react-native/gradle-plugin": "0.74.87",
     "@react-native/metro-config": "^0.73.2",
-    "@tsconfig/react-native": "^2.0.2",
     "@types/chai": "^4.3.4",
     "@types/jest": "^29.2.1",
     "@types/mocha": "^10.0.1",
@@ -52,11 +53,13 @@
     "@types/react-test-renderer": "^18.0.0",
     "@types/readable-stream": "^4.0.11",
     "babel-plugin-module-resolver": "^5.0.0",
-    "eslint": "^8.4.1",
+    "eslint": "9.9.1",
     "metro-react-native-babel-preset": "0.76.8",
-    "prettier": "^2.4.1"
+    "prettier": "3.3.3",
+    "typescript": "5.5.4",
+    "typescript-eslint": "8.3.0"
   },
   "jest": {
     "preset": "react-native"
   }
-}
+}

example/prettier.config.js

@@ -0,0 +1,7 @@
+export default {
+  arrowParens: 'avoid',
+  bracketSameLine: true,
+  bracketSpacing: true,
+  singleQuote: true,
+  trailingComma: 'all',
+};

example/src/components/Button.tsx

@@ -1,5 +1,6 @@
 import React from 'react';
 import { View, Text, TouchableOpacity, StyleSheet } from 'react-native';
+import { colors } from '../styles/colors';
 
 type ButtonProps = {
   title: string;
@@ -21,13 +22,13 @@ export const Button: React.FC<ButtonProps> = ({
 
 const styles = StyleSheet.create({
   container: {
-    backgroundColor: '#1976d2',
+    backgroundColor: colors.blue,
     padding: 10,
     borderRadius: 5,
     alignContent: 'center',
     justifyContent: 'center',
   },
   label: {
-    color: 'white',
+    color: colors.white,
   },
 });

example/src/components/IncorrectResultItem.tsx

@@ -1,5 +1,6 @@
 import React from 'react';
 import { View, Text, StyleSheet } from 'react-native';
+import { colors } from '../styles/colors';
 
 type IncorrectResultItemProps = {
   description: string;
@@ -32,6 +33,6 @@ const styles = StyleSheet.create({
     flexShrink: 1,
   },
   error: {
-    color: 'red',
+    color: colors.red,
   },
 });

example/src/components/Suite.tsx

@@ -11,15 +11,12 @@ export const Suite: React.FC<SuiteProps> = ({ description }: SuiteProps) => {
 
   return (
     <View style={styles.itemContainer}>
-      <Text style={[styles.text]}>{fullText}</Text>
+      <Text style={styles.text}>{fullText}</Text>
     </View>
   );
 };
 
 const styles = StyleSheet.create({
-  scroll: {
-    flex: 1,
-  },
   itemContainer: {
     borderWidth: 1,
     margin: 10,

example/src/components/TestItem.tsx

@@ -5,6 +5,7 @@ import type { TestResult } from '../types/TestResults';
 import { useNavigation } from '@react-navigation/native';
 import type { NativeStackNavigationProp } from '@react-navigation/native-stack';
 import type { RootStackParamList } from '../navigators/RootProps';
+import { colors } from '../styles/colors';
 
 type TestItemProps = {
   description: string;
@@ -80,7 +81,7 @@ const styles = StyleSheet.create({
     justifyContent: 'space-evenly',
     gap: 10,
     borderBottomWidth: 1,
-    borderBottomColor: '#ccc',
+    borderBottomColor: colors.gray,
   },
   checkbox: {
     transform: [{ scaleX: 0.7 }, { scaleY: 0.7 }],
@@ -94,10 +95,10 @@ const styles = StyleSheet.create({
     flexDirection: 'row',
   },
   pass: {
-    color: 'green',
+    color: colors.green,
   },
   fail: {
-    color: 'red',
+    color: colors.red,
   },
   count: {
     fontSize: 12,

example/src/hooks/useRunTests.ts

@@ -55,9 +55,9 @@ const run = (
     EVENT_SUITE_END,
   } = Mocha.Runner.constants;
 
-  let stats: Stats = { ...defaultStats };
+  const stats: Stats = { ...defaultStats };
 
-  var runner = new Mocha.Runner(rootSuite) as MochaTypes.Runner;
+  const runner = new Mocha.Runner(rootSuite) as MochaTypes.Runner;
   runner.stats = stats;
 
   // enable/disable tests based on checkbox value
@@ -68,7 +68,10 @@ const run = (
       s.tests.map((t) => {
         try {
           t.skip();
-        } catch (e) {} // do nothing w error
+        // eslint-disable-next-line @typescript-eslint/no-unused-vars
+        } catch (_e) {
+          // do nothing w error
+        }
       });
     } else {
       // console.log(`will run '${suiteName}' suite`);
@@ -86,7 +89,7 @@ const run = (
       stats.start = new Date();
     })
     .on(EVENT_SUITE_BEGIN, (suite: MochaTypes.Suite) => {
-      suite.root || stats.suites++;
+      if (suite.root) stats.suites++;
       indents++;
     })
     .on(EVENT_SUITE_END, () => {

example/src/hooks/useTestList.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-shadow */
 import { useState, useCallback } from 'react';
 import type * as MochaTypes from 'mocha';
 import type { Suites } from '../types/TestSuite';
@@ -8,8 +7,8 @@ import '../testing/tests/pbkdf2Tests/pbkdf2Tests';
 import '../testing/tests/RandomTests/randomTests';
 import '../testing/tests/HmacTests/HmacTests';
 import '../testing/tests/HashTests/HashTests';
-import '../testing/tests/CipherTests/CipherTestFirst';
-import '../testing/tests/CipherTests/CipherTestSecond';
+import '../testing/tests/CipherTests/CipherDecipher';
+import '../testing/tests/CipherTests/CipherivDecipheriv';
 import '../testing/tests/CipherTests/test398';
 import '../testing/tests/CipherTests/PublicCipherTests';
 import '../testing/tests/CipherTests/generateKey';
@@ -44,6 +43,7 @@ export const useTestList = (): [
 
   const clearAll = useCallback(() => {
     setSuites((suites) => {
+      // eslint-disable-next-line @typescript-eslint/no-unused-vars
       Object.entries(suites).forEach(([_, suite]) => {
         suite.value = false;
       });
@@ -53,6 +53,7 @@ export const useTestList = (): [
 
   const checkAll = useCallback(() => {
     setSuites((suites) => {
+      // eslint-disable-next-line @typescript-eslint/no-unused-vars
       Object.entries(suites).forEach(([_, suite]) => {
         suite.value = true;
       });
@@ -64,7 +65,7 @@ export const useTestList = (): [
 };
 
 const getInitialSuites = () => {
-  let suites: Suites = {};
+  const suites: Suites = {};
 
   // interrogate the loaded mocha suites/tests via a temporary runner
   const runner = new Mocha.Runner(rootSuite) as MochaTypes.Runner;

example/src/navigators/Root.tsx

@@ -2,6 +2,9 @@ import React from 'react';
 import { NavigationContainer } from '@react-navigation/native';
 import { createNativeStackNavigator } from '@react-navigation/native-stack';
 import type { RootStackParamList } from './RootProps';
+import { Entry } from './children/Entry/Entry';
+import { Benchmarks } from './children/benchmarks/Benchmarks';
+import { TestingScreen } from './children/TestingScreen/TestingScreen';
 
 const Stack = createNativeStackNavigator<RootStackParamList>();
 
@@ -15,14 +18,12 @@ export const Root: React.FC = () => {
             title: 'Test Suites',
           }}
           getComponent={() => {
-            const { Entry } = require('./children/Entry/Entry');
             return Entry;
           }}
         />
         <Stack.Screen
           name="Benchmarks"
           getComponent={() => {
-            const { Benchmarks } = require('./children/benchmarks/Benchmarks');
             return Benchmarks;
           }}
         />
@@ -32,9 +33,6 @@ export const Root: React.FC = () => {
             title: 'Tests',
           }}
           getComponent={() => {
-            const {
-              TestingScreen,
-            } = require('./children/TestingScreen/TestingScreen');
             return TestingScreen;
           }}
         />

example/src/navigators/children/Entry/Entry.tsx

@@ -14,7 +14,7 @@ import { useRunTests } from '../../../hooks/useRunTests';
 
 type EntryProps = NativeStackScreenProps<RootStackParamList, 'Entry'>;
 
-export const Entry: React.FC<EntryProps> = ({}: EntryProps) => {
+export const Entry: React.FC<EntryProps> = () => {
   const [tests, toggle, clearAll, checkAll] = useTestList();
   const [results, runTests] = useRunTests();
   const navigation =

example/src/styles/colors.ts

@@ -0,0 +1,7 @@
+export const colors: Record<string, string> = {
+  gray: '#ccc',
+  white: '#fff',
+  green: '#3cb043',
+  red: '#e60000',
+  blue: '#1976d2',
+};

example/src/testing/MochaRNAdapter.ts

@@ -2,7 +2,7 @@ import 'mocha';
 import type * as MochaTypes from 'mocha';
 
 // polyfill encoders for all tests
-// @ts-expect-error
+// @ts-expect-error - can't import but it's there
 import { polyfillGlobal } from 'react-native/Libraries/Utilities/PolyfillFunctions';
 import RNFE from 'react-native-fast-encoder';
 polyfillGlobal('TextEncoder', () => RNFE);
@@ -11,16 +11,13 @@ export const rootSuite = new Mocha.Suite('') as MochaTypes.Suite;
 rootSuite.timeout(10 * 1000);
 
 let mochaContext = rootSuite;
-let only = false;
 
 export const it = (
   name: string,
   f: MochaTypes.Func | MochaTypes.AsyncFunc
 ): void => {
-  if (!only) {
-    const test = new Mocha.Test(name, f);
-    mochaContext.addTest(test);
-  }
+  const test = new Mocha.Test(name, f);
+  mochaContext.addTest(test);
 };
 
 export const describe = (name: string, f: () => void): void => {

example/src/testing/fixtures/aes_cbc.ts

@@ -130,13 +130,13 @@ const decryptionFailing: AesEncryptDecryptTestVector[] = [];
 kKeyLengths.forEach(function (keyLength) {
   ['zeroPadChar', 'bigPadChar', 'inconsistentPadChars'].forEach(
     (paddingProblem) => {
-      // @ts-expect-error
+      // @ts-expect-error bad padding
       const badCiphertext = new Uint8Array(kCipherText[keyLength].byteLength);
       badCiphertext.set(
-        // @ts-expect-error
+        // @ts-expect-error bad padding
         kCipherText[keyLength].slice(0, kCipherText[keyLength].byteLength - 16)
       );
-      // @ts-expect-error
+      // @ts-expect-error bad padding
       badCiphertext.set(kBadPadding[keyLength][paddingProblem]);
 
       decryptionFailing.push({

example/src/testing/fixtures/aes_gcm.ts

@@ -137,7 +137,7 @@ kKeyLengths.forEach((keyLength) => {
         name: 'AES-GCM',
         iv,
         additionalData,
-        // @ts-expect-error
+        // @ts-expect-error bad tag length
         tagLength: badTagLength,
       },
       plaintext: kPlaintext,