[DST-494]: add loading states pattern #4152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
🦋 Changeset detectedLatest commit: b6349e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Coverage report
Show files with reduced coverage 🔻
Test suite run success570 tests passing in 78 suites. Report generated by 🧪jest coverage report action from b6349e7 |
aromko
force-pushed
the
DST-494_loading-states-usage-guidelines
branch
from
08c532c
to
fd1d596
Compare
KadaStrophe
approved these changes
Sep 17, 2024
KadaStrophe
previously approved these changes
Sep 17, 2024
Updated content to remove references to a one-second-delay, as we decided not to do this.
tirado-rx
previously approved these changes
Oct 8, 2024
tirado-rx
previously approved these changes
Oct 8, 2024
Added missing links, code formatting + made a few small wording changes to clarify points.
tirado-rx
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added the text 1:1 from https://reservix.atlassian.net/wiki/spaces/DST/pages/2817130498/Pattern+Loading+states.
The code examples are new and should fulfill the specs from https://www.figma.com/design/BiIiswcGDdv8v6q8pQA7Fq/Loading-States-specification?node-id=1-97&node-type=FRAME&t=aaISLAar05yuKUY3-0
Reviewers
@marigold-ui/developer
@marigold-ui/designer