catch unwanted removal of returning a dispatch #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for your awesome work. I want to propose this PR, because me and some folks of my team are running into an issue which is hard to identify and VERY time consuming.
const redial = { fetch: ({ dispatch, httpClient, props }) => dispatch(loadThings(httpClient, props.things)) };
When you have a redial object like this, you have no hint that it is necessary for fetch to return a promise. This is going to be a problem when you start debugging and put curly braces around the body of arrow function.
const redial = { fetch: ({ dispatch, httpClient, props }) => { console.log("props", props); dispatch(loadThings(httpClient, props.things)); } };
I couldn't think of any usecase where you don't want to return a promise to resolve after async operation. Maybe i'am wrong. What do you think?
greetings
Fabricius