Fixes restore script AWS configuration

[rjz]

This change removes environmental inference from the restore script, restoring the usual credential precedence established in aws-sdk. The default region (Sydney) is preserved for back-compatibility.

Thanks for your consideration!

[rjz]

@dylanlingelbach, any thoughts on this? Happy to address any suggestions (or concerns) stemming from the change.

[dylanlingelbach]

@rjz sorry for the delay - this looks good to me.

[dylanlingelbach]

Although I seem to have lost my write access to this repo. I'll figure out what is going on and get this merged.

[rjz]

Thanks, @dylanlingelbach! Much appreciated.

[johncmckim]

Bump on this PR. Restore won't work on Lambda without this fix.

[sdesalas]

LGTM

[rjz]

@dylanlingelbach, any word on this? Or any leads on who in markitx we might reach out to?

[dylanlingelbach]

@rjz sorry, no updates yet. I've been slammed at work the past few weeks. Will follow up and let you know. Worst case I will fork to my personal repo and move the npm package there

[rafaelmagu]

@dylanlingelbach any updates on this or other PRs being merged?

[dylanlingelbach]

@rafaelmagu still working on regaining write access. Sorry for the delay

[cg-cnu]

Hey guys,
Am set out to work on this issue #52
I saw this pr and wondering why the support for env variables is removed
@rjz mentioned that it is to

restoring the usual credential precedence established in aws-sdk.

Can some one guide me to what is the the credential precedence for node sdk
I searched the documentation, but could only find the one for java (look for Using the Default Credential Provider Chain)
Thanks 🙂

[dylanlingelbach]

@cg-cnu I think this link is what you are looking for

[cg-cnu]

@dylanlingelbach I guess its mostly talking about the ways in which you can load the credentials but not the order in which node SDK will work / prefer to work.
Is providing secrets using the environment variables considered insecure ?