Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Enable TimeSpan with null end #562

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

calien666
Copy link

This commit allows creating TimeSpan Object only with DTSTART set. As a starting time without ending is allowed in iCal definitions, this package should respect the ability having no end time set, too.

Fixes #561

This commit allows creating TimeSpan Object only with `DTSTART` set.
As a starting time without ending is allowed in iCal definitions,
this package should respect the ability having no end time set, too.
@markuspoerschke
Copy link
Owner

Moin Markus (@calien666),

thanks for your PR.

I have one question to this change:

What is the difference between a TimeSpan object with no end and a SingleDay object? Do you need to have an event without end-time in the middle of the week? If you want to have an event that just points to a day, then you can do it using the SingleDay.

Can you outline the use case here? I would be interested into the look in the calendar app as well. Would be nice to see a screenshot.

@calien666
Copy link
Author

Moin Markus (@markuspoerschke),
The difference between a TimeSpan without end and a SingleDay Event is, the event has a starting time, but no ending, while a SingleDay event is whole day located.

The most affectible use case ist, the importing calendar decides, how long the event will be lasting according to the default timespan set up by the calendar default settings. I'll take a look on an example.

Possibly there could be a separate class added, which is called TimeStart or something instead of nulling TimeSpan end time. But I'm not sure, if this is a possible use or not. Let me check, how calendar applications handle these events and then I can make a better descision.

@markuspoerschke
Copy link
Owner

Understand. Makes sense in my opinion. Also, I would keep the way you implemented it.

Can you please adjust the following in your pull-request?

  1. Add an entry to the changelog file
  2. Add at least one test that is covering the new feature
  3. Add instructions to the documentation how to use the open end time span

@calien666
Copy link
Author

Hey @markuspoerschke,
sorry for reacting that late. I hope, I will finish it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Enable TimeSpan work with only start Time
2 participants