Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract base name from URLs correctly #836

Draft
wants to merge 3 commits into
base: mainline
Choose a base branch
from
Draft

Extract base name from URLs correctly #836

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9eb3c71
Extract base name from URLs correctly
farshidz May 14, 2024
061cfc4
Merge branch 'mainline' into farshid/fix-model-cache-filename
farshidz Jun 20, 2024
123a1a5
Merge branch 'mainline' into farshid/fix-model-cache-filename
farshidz Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/marqo/s2_inference/processing/custom_clip_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from urllib.parse import urlparse

import regex as re
from typing import Union, List, Optional
import ftfy
Expand Down Expand Up @@ -145,7 +147,7 @@ def download_pretrained_from_url(
os.makedirs(cache_dir, exist_ok=True)

if cache_file_name is None:
filename = os.path.basename(url)
filename = os.path.basename(urlparse(url).path)
else:
filename = cache_file_name

Expand Down
Loading