feat: 내가 받은 픽 정보 오픈 API #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xonmin
reviewed
Jul 21, 2024
toychip
approved these changes
Jul 21, 2024
yaeoni
approved these changes
Jul 21, 2024
_endpoint_test/pick.http
Outdated
Comment on lines
5
to
23
| ### 픽 정보 오픈하기 | ||
|
|
||
| POST {{host}}/pick/open | ||
| Content-Type: application/json | ||
|
|
||
| { | ||
| "pickId": "pickId", | ||
| "pickOpenItem": "GENDER" | ||
| } | ||
|
|
There was a problem hiding this comment.
픽 정보 오픈 시 내부 로직에서 해당 정보를 오픈했다는 업데이트를 수행해서 POST로 작성했습니당
Comment on lines
26
to
38
| @Schema(description = "픽 오픈 요청") | ||
| data class PickOpenRequest( | ||
| @field:NotBlank | ||
| val pickId: PickId, | ||
| @field:NotNull | ||
| val pickOpenItem: PickOpenItem, | ||
| ) |
There was a problem hiding this comment.
pickOpenItem 도메인이 여까지 올라오는군요?
There was a problem hiding this comment.
별도 클래스 정의해서 사용하는게 적합할까요..?! 도메인을 어느 레벨까지 가져와서 쓰는게 적당할지 고민되네욤..
wonlog-g
force-pushed
the
sewon/open-pick
branch
from
26f2169
to
f3deb10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[add] pr template작업 내용
내가 받은 픽의 정보 중 하나를 오픈합니다.