-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 내가 받은 픽 정보 오픈 API #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 작업해주신게 클라이언트에서 pick 오픈 시, openItem 에 따라 맞추어 responseDTO
에 value 로 응답 전달되는 것으로 이해했는데요
openItem 에 따라 전달되는 성별, 플랫폼, 초성, 이름
등 분기되는 로직은 추가되어야할 것 같습니다!
이해한 바로 우선 코멘트 남겼는데 틀린 부분이나 다른 생각 가지고 있는 거라면 알려주시면 감사하겠습니다 ( _ _ )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
픽 정보 오픈 API 확인했습니다.
고생하셨습니다~!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨어용!
_endpoint_test/pick.http
Outdated
### 픽 정보 오픈하기 | ||
|
||
POST {{host}}/pick/open | ||
Content-Type: application/json | ||
|
||
{ | ||
"pickId": "pickId", | ||
"pickOpenItem": "GENDER" | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 픽 정보를 오픈하는데 POST 요청이군용
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
픽 정보 오픈 시 내부 로직에서 해당 정보를 오픈했다는 업데이트를 수행해서 POST로 작성했습니당
@Schema(description = "픽 오픈 요청") | ||
data class PickOpenRequest( | ||
@field:NotBlank | ||
val pickId: PickId, | ||
@field:NotNull | ||
val pickOpenItem: PickOpenItem, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pickOpenItem 도메인이 여까지 올라오는군요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
별도 클래스 정의해서 사용하는게 적합할까요..?! 도메인을 어느 레벨까지 가져와서 쓰는게 적당할지 고민되네욤..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
몇가지 코멘트 남겼습니다 ㅎㅎㅎ
고생하셨습니다
26f2169
to
f3deb10
Compare
[add] pr template
작업 내용
내가 받은 픽의 정보 중 하나를 오픈합니다.