Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fine debugging #107

Merged
merged 17 commits into from
Aug 8, 2023
Merged

Fix/fine debugging #107

merged 17 commits into from
Aug 8, 2023

Conversation

hope1053
Copy link
Member

@hope1053 hope1053 commented Aug 8, 2023

What is this PR? ๐Ÿ”

Changes ๐Ÿ“

๋ฒŒ๊ธˆ์ชฝ ๊ธฐ๋Šฅ ์ „๋ฐ˜์ ์œผ๋กœ ํ…Œ์ŠคํŠธ ๋ฐ ๋””๋ฒ„๊น… ์ง„ํ–‰ํ–ˆ์Šต๋‹ˆ๋‹ค ~

  • ๋ฒŒ๊ธˆ ์ธ์ฆ (์‚ฌ์ง„ ์—…๋กœ๋“œ)ํŽ˜์ด์ง€ routing ๊ฐ์ฒด FineList โ†’ MOITDetail๋กœ ๋ณ€๊ฒฝ
  • NetworkImpl์—์„œ checkError ํ”„๋กœ์„ธ์Šค ์ค‘ data ์˜ต์…”๋„ ์ฒ˜๋ฆฌ๊ฐ€ ํ•„์š”ํ•ด์„œ ๋„คํŠธ์›Œํฌ ๋กœ์ง(Repository, Usecase)๋“ค์— compact map ์ถ”๊ฐ€
  • ๋ฒŒ๊ธˆ ๋‚ฉ๋ถ€ ์ด๋ฏธ์ง€ ๋“ฑ๋ก/์Šน์ธ/๊ฑฐ์ ˆ ๋กœ์ง ์˜ค๋ฅ˜ ์ˆ˜์ •
  • ๋ฒŒ๊ธˆ ๋‚ฉ๋ถ€ ์Šน์ธ ํŽ˜์ด์ง€ ์žฌ์ธ์ฆ ์š”์ฒญ/์ธ์ฆ ํ™•์ธ ๋ฒ„ํŠผ title ๋ฐ width ์ˆ˜์ •
  • ๋ฒŒ๊ธˆ ๊ด€๋ จ ๊ฐ์ข… ํ”Œ๋กœ์šฐ ์™„๋ฃŒ ํ›„ ํ† ์ŠคํŠธ ๋ณด์—ฌ์ค˜์•ผํ•˜๋Š” ๊ฒฝ์šฐ showToast ์ถ”๊ฐ€
  • FineList viewWillAppear ๋  ๋•Œ ๋ฐ์ดํ„ฐ ๊ฐฑ์‹ ๋˜๋„๋ก ์ˆ˜์ •
  • ๋ฒŒ๊ธˆ NumberFormatter ์ ์šฉ

Screenshot ๐Ÿ“ธ

๋…นํ™”๋ฅผ ๊นœ๋นก.,,,,ํ–ˆ์Šต๋‹ˆ๋‹ค,,, ๋ฐ์ดํ„ฐ ์—ฌ๋Ÿฌ๊ฐœ ์ƒ์„ฑํ•ด๋†จ์œผ๋‹ˆ ์ข€์ด๋”ฐ ๋ฐค์— ๊ฐ™์ด ๋ณด๋„๋ก ํ•˜์‹œ์ฃ ,,,^^

To Reviewers ๐Ÿ™

@hope1053 hope1053 self-assigned this Aug 8, 2023
@hope1053 hope1053 merged commit b8fc95a into develop Aug 8, 2023
1 check failed
@hope1053 hope1053 deleted the fix/fine-debugging branch August 8, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant