Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/밈상세화면 구현 #23 #28

Merged
merged 18 commits into from
Jun 29, 2024
Merged

Feature/밈상세화면 구현 #23 #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
8cd980c
feat: memeDetail 모듈 추가
chansooo Jun 29, 2024
84fe57d
feat: kingfisher 추가
chansooo Jun 29, 2024
ea57ea7
Merge branch 'develop' into feature/밈상세화면-구현-#23
chansooo Jun 29, 2024
3bc5590
design: ㅋ, 개웃겨 리소스 추가
chansooo Jun 29, 2024
cda43d1
feat: MemeDetail 모델 구현
chansooo Jun 29, 2024
440f0a0
feat: MemeDetail UI 구현
chansooo Jun 29, 2024
620ec7b
chore: 코드리뷰 봇 무시
chansooo Jun 29, 2024
c6e7c2a
refactor: 재사용 가능한 뷰 분리
chansooo Jun 29, 2024
e06ddd2
move: 파일 경로 변경
chansooo Jun 29, 2024
5ef9917
feat: util 관련 router, viewmodeltype 구현
chansooo Jun 29, 2024
dfdde9e
fix: farmemedetail에 id 필드 추가
chansooo Jun 29, 2024
c812b5a
feat: 상세에서 필요한 usecase 정의
chansooo Jun 29, 2024
36709fb
feat: memedetailviewmodel 구현
chansooo Jun 29, 2024
ee9112b
Merge branch 'develop' into feature/밈상세화면-구현-#23
chansooo Jun 29, 2024
dd00cef
infra: home에 memedetail 디펜던시 추가
chansooo Jun 29, 2024
a09492e
Merge branch 'feature/밈상세화면-구현-#23' of https://github.com/mash-up-kr/…
chansooo Jun 29, 2024
e1be12e
chore: 중복 코드 삭제
chansooo Jun 29, 2024
c158cf4
Merge branch 'develop' into feature/밈상세화면-구현-#23
chansooo Jun 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Projects/Features/Home/Project.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,10 @@ let project = Project(
resources: "Resources/**",
dependencies: [
.ThirdParty.Dependency,
// .ResourceKit,
.ResourceKit,
.Core.DesignSystem,
.Core.PPACModels,
.Feature.MemeDetail,
]
)
]
Expand Down
40 changes: 0 additions & 40 deletions Projects/Features/MemeDetail/Sources/HashTagView.swift
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions Projects/Features/MemeDetail/Sources/LikeButton.swift
View file
Open in desktop

This file was deleted.

71 changes: 0 additions & 71 deletions Projects/Features/MemeDetail/Sources/MemeDetailCardView.swift
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions Projects/Features/MemeDetail/Sources/MemeDetailView.swift
View file
Open in desktop

This file was deleted.

36 changes: 0 additions & 36 deletions Projects/Features/MemeDetail/Sources/MemeImageView.swift
View file
Open in desktop

This file was deleted.

6 changes: 1 addition & 5 deletions Projects/Features/MemeDetail/Sources/Presentation/MemeDetailRouter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,7 @@ final class MemeDetailRouter: Router {
self.meme = meme
self.navigationController = navigationController
}

// MARK: - UI

// MARK: - Override


// MARK: - Methods

func start() {
Expand Down
1 change: 1 addition & 0 deletions Tuist/ProjectDescriptionHelpers/TargetDependency+.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ extension TargetDependency {
public static let Recommend = project(moduleName: "Recommend")
public static let Search = project(moduleName: "Search")
public static let MyPage = project(moduleName: "MyPage")
public static let MemeDetail = project(moduleName: "MemeDetail")
}

public struct Core {
Expand Down
Loading