66 add news improvements #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd-news-improvements
|
@alexcoaton linting passing, tests failing as automatic tests yet to be written |
alexcoaton
requested changes
Jul 12, 2022
| @@ -45,6 +45,7 @@ export default function App() { | |||
| <Routes> | |||
| <Route path="/" element={<AdminGardens />} /> | |||
| <Route path="/admin/gardens/add" element={<AddGarden />} /> | |||
| <Route path="/gardens/news/add" element={<AddNews />} /> | |||
| <Route | |||
| path="/admin/gardens/:id/news/add" | |||
| element={ | |||
There was a problem hiding this comment.
I think this route should be admin/news/add no? If it's an admin only feature.
| ) : null} | ||
| <Field | ||
| className="border-2 border-lightGreen bg-white rounded-sm w-5/6" | ||
| //specfic to dropdown formatting? |
There was a problem hiding this comment.
If this comment is resolved, remove it.
| Gardens | ||
| </label> | ||
| {errors.gardenId && touched.gardenId ? ( | ||
| <div>{errors.gardenId}</div> |
There was a problem hiding this comment.
Is this what results in the "Required" text in the view? Should it read "*required" and be styled in red perhaps?
| @@ -1,28 +1,36 @@ | |||
| import React from 'react' | |||
| import { render, screen, waitFor } from '@testing-library/react' | |||
| import userEvent from '@testing-library/user-event' | |||
|
|
|||
| // import renderWithRedux from '@testing-library/render-with-redux' | |||
| import NewsForm from './NewsForm' | ||
|
|
||
| // make mock.jest data like news.test |
There was a problem hiding this comment.
And the rest of the commented code below.
| formData={initialState} | ||
| action="Create News" | ||
| initialFormData={initialFormData} | ||
| action="Post News" |
There was a problem hiding this comment.
Rename this to something more friendly like formTitle="Post News". With the name action, it looks like it's supposed to do something else, like a callback or dispatch a redux action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#66