Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #1029

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

pasha28091997
Copy link

Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ 👍 But some fixes are required
Also, add favicon

return;
}

updateUI();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I click any button before clicking start the message disappears and the button text changes:

image

Also, change the font size for restart button to fit text

const column = this.getColumn(col).reverse();
const newColumn = this.merge(this.slide(column)).reverse();

if (!this.arraysEqual(column, newColumn)) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes it doesn't work properly:

image

Then I clicked Down button, result:

image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
You can add a better favicon on the page
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants