game #425
Open
game #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polosanya
suggested changes
Jul 31, 2023
src/scripts/main.js
Outdated
| randomCellFill(); | ||
| }; | ||
|
|
||
| function isMergePossible() { |
There was a problem hiding this comment.
You used arrow functions above and function declaration here.
Stay strict to one way of creating functions for concise and readable code
src/index.html
Outdated
Comment on lines
65
to
67
| </body> | ||
|
|
||
| </html> |
There was a problem hiding this comment.
Suggested change
| </body> | |
| </html> | |
| </body> | |
| </html> |
Don't leave empty lines between parent and child elements
Comment on lines
+145
to
+147
| case 'ArrowLeft': | ||
| arrowLeft(); | ||
| break; |
There was a problem hiding this comment.
switch...case should always have a default case to handle possible errors
src/scripts/main.js
Outdated
|
|
||
| function rotateCells(line) { | ||
| for (let i = 3; i > 0; i--) { | ||
| const moveAllowed = clearCells.includes(line[i]) |
There was a problem hiding this comment.
Suggested change
| const moveAllowed = clearCells.includes(line[i]) | |
| const isMoveAllowed = clearCells.includes(line[i]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK](https://diana-tuz.github.io/js_2048_game/)