Hw oop advanced #1714

sannchous · 2024-10-09T18:36:57Z

No description provided.

mateacademy-ai-mentor

Great job on your code! You've adhered to the task requirements and checklist well. There are no significant issues in your code. Keep up the good work! 🌟

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

mateacademy-ai-mentor · 2024-10-09T18:42:15Z

src/main/java/core/basesyntax/Figure.java

@@ -0,0 +1,19 @@
+package core.basesyntax;
+
+public abstract class Figure implements Draw {


According to the checklist, we should avoid using abstract classes to set behavior for classes. Instead, you should use interfaces. In this case, you could create an interface named 'Figure' with the method 'getArea()' and another interface named 'Colored' with the methods 'getColor()' and 'setColor(String color)'. Then, each figure class could implement these interfaces as needed.

mateacademy-ai-mentor · 2024-10-09T18:42:15Z

src/main/java/core/basesyntax/Figure.java

+        this.color = color;
+    }
+
+    public abstract double getArea();


This method 'getArea()' should be in a separate interface. The 'Figure' class should only deal with properties that are common to all figures, like color. The calculation of the area is specific to each type of figure, so it should be in a separate interface.

mateacademy-ai-mentor · 2024-10-09T18:42:16Z

src/main/java/core/basesyntax/FigureSupplier.java

+                int side = random.nextInt(MAXIMUM);
+                return new Square(color, side);
+            case 1:
+                int firstSide = random.nextInt(MAXIMUM);
+                int secondSide = random.nextInt(MAXIMUM);
+                return new Rectangle(color, firstSide, secondSide);
+            case 2:
+                int firstLeg = random.nextInt(MAXIMUM);
+                int secondLeg = random.nextInt(MAXIMUM);
+                return new RightTriangle(color, firstLeg, secondLeg);
+            case 3:
+                int radius = random.nextInt(MAXIMUM);
+                return new Circle(color, radius);
+            case 4:
+                int firstBase = random.nextInt(MAXIMUM);
+                int secondBase = random.nextInt(MAXIMUM);
+                int height = random.nextInt(MAXIMUM);


Creating a figure, don't pass expressions in the constructor. Create separate variables and pass them on for better code readability. It will make your code cleaner and easier to debug.

mateacademy-ai-mentor · 2024-10-09T18:42:16Z

src/main/java/core/basesyntax/FigureSupplier.java

+    }
+
+    public Figure getDefaultFigure() {
+        return new Circle(Color.WHITE.name(), 10);


It's better to create a constant for the default figure size. It's a good practice to extract magic numbers into constants. It makes your code easier to read and maintain.

mateacademy-ai-mentor · 2024-10-09T18:42:16Z

src/main/java/core/basesyntax/IsoscelesTrapezoid.java

+        System.out.println("The Figure: Trapezoid; First base = " + firstBase
+                + "   Second base = " + secondBase + " Height = " + height
+                + "\n" + " Area: " + getArea()
+                + "; Color: " + getColor() + "\n");


You should avoid using string concatenation in System.out.println() statement. It's better to use String.format() method for such purposes. This way you can create a template for your message and then just pass the required variables as arguments. It will also help to avoid potential issues with '+' operator precedence.

mateacademy-ai-mentor · 2024-10-09T18:42:16Z

src/main/java/core/basesyntax/IsoscelesTrapezoid.java

+    public double getArea() {
+        return 0.5 * (firstBase + secondBase) * height;
+    }


According to the checklist, all magic numbers in your code should be constants. Here, 0.5 is a magic number. Please, create a constant for it.

JJJazl · 2024-10-10T08:13:34Z

src/main/java/core/basesyntax/Area.java

+
+public interface Area {
+    double getArea();
+


Remove all redundant empty lines, be careful :)

JJJazl · 2024-10-10T08:13:58Z

src/main/java/core/basesyntax/Area.java

@@ -0,0 +1,6 @@
+package core.basesyntax;
+
+public interface Area {


Don't use verbs for class/interface names
https://github.com/mate-academy/jv-oop-advanced/blob/master/checklist.md#dont-use-verbs-for-classinterface-names

Seem like you don't use this interface anywhere, so instead of abstract method in class Figure just implement this interface

JJJazl · 2024-10-10T08:15:05Z

src/main/java/core/basesyntax/Area.java

+package core.basesyntax;
+
+public interface Area {
+    double getArea();


Better name will be calculateArea()

JJJazl · 2024-10-10T08:16:30Z

src/main/java/core/basesyntax/Draw.java

@@ -0,0 +1,5 @@
+package core.basesyntax;
+
+public interface Draw {


Don't use verbs for class/interface names
https://github.com/mate-academy/jv-oop-advanced/blob/master/checklist.md#dont-use-verbs-for-classinterface-names

JJJazl · 2024-10-10T08:17:05Z

src/main/java/core/basesyntax/Draw.java

+package core.basesyntax;
+
+public interface Draw {
+    void toDraw();


Better name will be draw()

JJJazl · 2024-10-10T08:26:53Z

src/main/java/core/basesyntax/Circle.java

+        System.out.println("The Figure: Circle; radius = " + radius
+                + "\n" + " Area: " + getArea()
+                + "; Color: " + getColor() + "\n");
+    }


Please, pay attention to the example result in task description. For all figures

JJJazl · 2024-10-10T08:29:14Z

src/main/java/core/basesyntax/ColorSupplier.java

+    private static final Random random = new Random();
+
+    public String getRandomColor() {
+        int index = random.nextInt(Color.values().length);
+        Color color = Color.values()[index];
+        return color.name();
+    }
+


You can create a constant variable to save number of colors and you can use this constant in method random.nextInt()

JJJazl · 2024-10-10T08:31:22Z

src/main/java/core/basesyntax/FigureSupplier.java

+    }
+
+    public Figure getDefaultFigure() {
+        return new Circle(Color.WHITE.name(), 10);


All magic numbers in your code should be constants
https://github.com/mate-academy/jv-oop-advanced/blob/master/checklist.md#all-magic-numbers-in-your-code-should-be-constants

JJJazl · 2024-10-10T08:34:07Z

src/main/java/core/basesyntax/Main.java

+ */
+public class Main {
+    public static void main(String[] args) {
+        Figure[] figures = new Figure[6];


All magic numbers in your code should be constants
https://github.com/mate-academy/jv-oop-advanced/blob/master/checklist.md#all-magic-numbers-in-your-code-should-be-constants

JJJazl · 2024-10-10T08:34:58Z

src/main/java/core/basesyntax/Main.java

+        for (int i = 0; i < figures.length; i++) {
+            figures[i] = (i <= figures.length / 2 - 1)
+                    ? figureSupplier.getRandomFigure()
+                    : figureSupplier.getDefaultFigure();
+        }


You can calculate the middle of figures array before loop and just use it value in if statement

sannchous added 3 commits October 9, 2024 20:45

created classes and interfaces for figures

5e78d8b

solved task, correct mistakes, create random methods

503f06b

fixed test-errors, correct syntax

617a941

mateacademy-ai-mentor approved these changes Oct 9, 2024

View reviewed changes

JJJazl suggested changes Oct 10, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hw oop advanced #1714

Hw oop advanced #1714

sannchous commented Oct 9, 2024

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor Oct 9, 2024

mateacademy-ai-mentor Oct 9, 2024

mateacademy-ai-mentor Oct 9, 2024

mateacademy-ai-mentor Oct 9, 2024

mateacademy-ai-mentor Oct 9, 2024

mateacademy-ai-mentor Oct 9, 2024

JJJazl Oct 10, 2024

JJJazl Oct 10, 2024

JJJazl Oct 10, 2024

JJJazl Oct 10, 2024

JJJazl Oct 10, 2024

JJJazl Oct 10, 2024

JJJazl Oct 10, 2024

JJJazl Oct 10, 2024

JJJazl Oct 10, 2024

JJJazl Oct 10, 2024

		@@ -0,0 +1,19 @@
		package core.basesyntax;

		public abstract class Figure implements Draw {

		@@ -0,0 +1,6 @@
		package core.basesyntax;

		public interface Area {

		@@ -0,0 +1,5 @@
		package core.basesyntax;

		public interface Draw {

Hw oop advanced #1714

Are you sure you want to change the base?

Hw oop advanced #1714

Conversation

sannchous commented Oct 9, 2024

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment