Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First commit #1716

Closed
wants to merge 1 commit into from
Closed

Conversation

lisichenkowork
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've done a great job, but there are a few issues that need to be addressed. You need to correct the formulas for calculating the area in some classes, also remember to follow Java naming conventions for methods and interfaces. Avoid using abstract classes to set behavior for classes, instead, use interfaces. Make sure each class and interface has a single responsibility. Keep up the good work! 👍

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/main/java/core/basesyntax/Circle.java Show resolved Hide resolved
src/main/java/core/basesyntax/Circle.java Show resolved Hide resolved
src/main/java/core/basesyntax/Square.java Show resolved Hide resolved
src/main/java/core/basesyntax/Square.java Show resolved Hide resolved
src/main/java/core/basesyntax/Square.java Show resolved Hide resolved
src/main/java/core/basesyntax/Square.java Show resolved Hide resolved
src/main/java/core/basesyntax/Square.java Show resolved Hide resolved
@lisichenkowork
Copy link
Author

done

@lisichenkowork lisichenkowork closed this by deleting the head repository Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants