Solution jv-oop-advanced #1721

SnkvS · 2024-10-18T16:38:55Z

No description provided.

mateacademy-ai-mentor

Thank you for your hard work on this pull request! There are a few critical issues that need to be addressed, such as the incorrect class name in the toString() method and the use of an abstract class to set behavior. Once these are resolved, your code will be in great shape. Keep up the great work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

mateacademy-ai-mentor · 2024-10-18T16:39:06Z

src/main/java/core/basesyntax/Circle.java

+        return radius;
+    }
+
+    public void setRadius(int radius) {


The parameter type for the setRadius method should be consistent with the type of the radius field, which is double. Consider changing the parameter type from int to double.

mateacademy-ai-mentor · 2024-10-18T16:39:07Z

src/main/java/core/basesyntax/ColorSupplier.java

+    public String getRandomColor() {
+        return Colors.values()[random.nextInt(Colors.values().length)].toString();


Instead of using toString() to get the String representation of an enum constant, use the name() method. This ensures consistency and avoids issues if toString() is overridden.

mateacademy-ai-mentor · 2024-10-18T16:39:07Z

src/main/java/core/basesyntax/Figure.java

@@ -0,0 +1,14 @@
+package core.basesyntax;
+
+public abstract class Figure implements AreaCalculator, Drawable {


The class Figure is using an abstract class to set behavior by implementing both AreaCalculator and Drawable interfaces. According to the checklist, abstract classes should not be used to set behavior. Consider using interfaces to define behaviors instead.

mateacademy-ai-mentor · 2024-10-18T16:39:07Z

src/main/java/core/basesyntax/Figure.java

+
+public abstract class Figure implements AreaCalculator, Drawable {
+    private String color;
+    private double area;


The area field is declared but not used in this class. If it's intended to store the area of the figure, consider calculating and setting it within the class methods or remove it if it's unnecessary.

mateacademy-ai-mentor · 2024-10-18T16:39:07Z

src/main/java/core/basesyntax/FigureSupplierImpl.java

+
+import java.util.Random;
+
+public class FigureSupplierImpl implements FigureSupplier {


The class name FigureSupplierImpl uses a verb, which is not recommended. Consider renaming it to something like FigureSupplierImplementation or another noun-based name.

mateacademy-ai-mentor · 2024-10-18T16:39:07Z

src/main/java/core/basesyntax/FigureSupplierImpl.java

+    @Override
+    public Figure getDefaultFigure() {
+        var c = new Circle(10.0);
+        c.setColor(Colors.WHITE.toString());


The checklist advises using name() instead of toString() for getting the string representation of enum constants. Replace Colors.WHITE.toString() with Colors.WHITE.name().

mateacademy-ai-mentor · 2024-10-18T16:39:07Z

src/main/java/core/basesyntax/IsoscelesTrapezoid.java

@@ -0,0 +1,58 @@
+package core.basesyntax;
+
+public class IsoscelesTrapezoid extends Figure {


Don't use verbs for class/interface names. Consider renaming IsoscelesTrapezoid to a noun form if possible, although in this case, it might be acceptable as it is a specific shape name.

mateacademy-ai-mentor · 2024-10-18T16:39:07Z

src/main/java/core/basesyntax/Main.java

+
+public class Main {
+    public static void main(String[] args) {
+        var supplierFigure = new FigureSupplierImpl();


It's recommended not to use 'var' for variable declarations in this context. Instead, specify the type explicitly for better readability and understanding of the code.

mateacademy-ai-mentor · 2024-10-18T16:39:07Z

src/main/java/core/basesyntax/Main.java

+public class Main {
+    public static void main(String[] args) {
+        var supplierFigure = new FigureSupplierImpl();
+        var supplierColor = new ColorSupplier();


It's recommended not to use 'var' for variable declarations in this context. Instead, specify the type explicitly for better readability and understanding of the code.

mateacademy-ai-mentor · 2024-10-18T16:39:08Z

src/main/java/core/basesyntax/RightTriangle.java

+
+    @Override
+    public String toString() {
+        final StringBuilder sb = new StringBuilder("Rectangle{");


There is a mistake in the toString() method. The class name should be RightTriangle instead of Rectangle.

mateacademy-ai-mentor

Great job on implementing the classes and interfaces! 🎉 While there are a few areas for improvement, such as ensuring array lengths are even and avoiding returning null from methods, your work aligns well with the task requirements. Remember to address these issues in future projects to enhance your code quality. Keep up the good work and continue learning from these experiences!

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

mateacademy-ai-mentor · 2024-10-18T16:47:37Z

src/main/java/core/basesyntax/AreaCalculator.java

@@ -0,0 +1,5 @@
+package core.basesyntax;
+
+public interface AreaCalculator {


The interface name 'AreaCalculator' is a noun, which is good. However, make sure that this interface is used only for calculating areas, as per the checklist item: 'Don't put all behavior into a single interface if the methods are conceptually different from each other.'

mateacademy-ai-mentor · 2024-10-18T16:47:37Z

src/main/java/core/basesyntax/Circle.java

@@ -0,0 +1,35 @@
+package core.basesyntax;
+
+public class Circle extends Figure {


The class name 'Circle' is appropriate as it is a noun and represents an entity.

mateacademy-ai-mentor · 2024-10-18T16:47:37Z

src/main/java/core/basesyntax/Circle.java

+    }
+
+    @Override
+    public double calculateArea() {


The method 'calculateArea' is correctly overridden to calculate the area of the circle.

mateacademy-ai-mentor · 2024-10-18T16:47:37Z

src/main/java/core/basesyntax/Circle.java

+    }
+
+    @Override
+    public String toString() {


The 'toString' method provides a string representation of the Circle object, which is useful for debugging and logging.

mateacademy-ai-mentor · 2024-10-18T16:47:37Z

src/main/java/core/basesyntax/Circle.java

+    }
+
+    @Override
+    public void draw() {


The 'draw' method is correctly overridden to print the Circle object, which aligns with the Drawable interface.

mateacademy-ai-mentor · 2024-10-18T16:47:38Z

src/main/java/core/basesyntax/Main.java

+
+public class Main {
+    public static void main(String[] args) {
+        FigureSupplier supplierFigure = new FigureSupplierImplementation();


Avoid using verbs for class names. Consider renaming FigureSupplierImplementation to something more descriptive and noun-based, like FigureSupplierImpl.

mateacademy-ai-mentor · 2024-10-18T16:47:38Z

src/main/java/core/basesyntax/Main.java

+        FigureSupplier supplierFigure = new FigureSupplierImplementation();
+        ColorSupplier supplierColor = new ColorSupplier();
+        Figure[] array = new Figure[6];
+        for (int i = 0; i < array.length / 2; i++) {


The loop condition i < array.length / 2 is correct, but ensure that the array length is even to avoid potential issues. If the length is odd, this logic might not fill the array as intended.

mateacademy-ai-mentor · 2024-10-18T16:47:39Z

src/main/java/core/basesyntax/Rectangle.java

@@ -0,0 +1,47 @@
+package core.basesyntax;


Don't use verbs for class/interface names. Consider renaming Rectangle to a noun form if applicable.

mateacademy-ai-mentor · 2024-10-18T16:47:39Z

src/main/java/core/basesyntax/RightTriangle.java

@@ -0,0 +1,48 @@
+package core.basesyntax;
+
+public class RightTriangle extends Figure {


The class name 'RightTriangle' is appropriate as it represents a noun, which is a good practice for class names.

mateacademy-ai-mentor · 2024-10-18T16:47:39Z

src/main/java/core/basesyntax/RightTriangle.java

+        final StringBuilder sb = new StringBuilder("RightTriangle{");
+        sb.append("firstLeg=").append(firstLeg);
+        sb.append(", secondLeg=").append(secondLeg);
+        sb.append(", color").append(getColor());


There is a missing '=' sign in the toString() method for the 'color' field. It should be 'sb.append(", color=").append(getColor());'.

Solution jv-oop-advanced

5fe068c

mateacademy-ai-mentor suggested changes Oct 18, 2024

View reviewed changes

Fixes as per comments

e26aaf5

SnkvS requested a review from mateacademy-ai-mentor October 18, 2024 16:47

mateacademy-ai-mentor approved these changes Oct 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Solution jv-oop-advanced #1721

Solution jv-oop-advanced #1721

SnkvS commented Oct 18, 2024

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor Oct 18, 2024

mateacademy-ai-mentor Oct 18, 2024

mateacademy-ai-mentor Oct 18, 2024

mateacademy-ai-mentor Oct 18, 2024

mateacademy-ai-mentor Oct 18, 2024

mateacademy-ai-mentor Oct 18, 2024

mateacademy-ai-mentor Oct 18, 2024

mateacademy-ai-mentor Oct 18, 2024

mateacademy-ai-mentor Oct 18, 2024

mateacademy-ai-mentor Oct 18, 2024

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor Oct 18, 2024

mateacademy-ai-mentor Oct 18, 2024

mateacademy-ai-mentor Oct 18, 2024

mateacademy-ai-mentor Oct 18, 2024

mateacademy-ai-mentor Oct 18, 2024

mateacademy-ai-mentor Oct 18, 2024

mateacademy-ai-mentor Oct 18, 2024

mateacademy-ai-mentor Oct 18, 2024

mateacademy-ai-mentor Oct 18, 2024

mateacademy-ai-mentor Oct 18, 2024

		public String getRandomColor() {
		return Colors.values()[random.nextInt(Colors.values().length)].toString();

		@@ -0,0 +1,14 @@
		package core.basesyntax;

		public abstract class Figure implements AreaCalculator, Drawable {


		import java.util.Random;

		public class FigureSupplierImpl implements FigureSupplier {

		@@ -0,0 +1,58 @@
		package core.basesyntax;

		public class IsoscelesTrapezoid extends Figure {

		@@ -0,0 +1,5 @@
		package core.basesyntax;

		public interface AreaCalculator {

		@@ -0,0 +1,35 @@
		package core.basesyntax;

		public class Circle extends Figure {

		@@ -0,0 +1,48 @@
		package core.basesyntax;

		public class RightTriangle extends Figure {

Solution jv-oop-advanced #1721

Are you sure you want to change the base?

Solution jv-oop-advanced #1721

Conversation

SnkvS commented Oct 18, 2024

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment