-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jv-oop-advanced task is done #1736
jv-oop-advanced task is done #1736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 😊 It looks like there are a few critical issues that need to be addressed before we can approve the pull request. Here are the key areas that require attention:
-
Implementation of Required Methods: Several classes, such as
FigureSupplier
,ColorSupplier
, and the figure classes (Circle
,Square
,RightTriangle
,Rectangle
,IsoscelesTrapezoid
), are missing essential methods for functionality like generating random figures and colors, calculating areas, and setting colors. -
Interface and Abstract Class Design: The
AreaCalculator
interface andFigure
abstract class need to be properly designed to include methods for area calculation and color setting. TheDrawable
interface should also define adraw
method. -
Enum and Class Structure: The
Color
enum is empty and should define constants for different colors. The class names and package structure should reflect their purpose and adhere to the task requirements. -
Main Class Functionality: The
main()
method in theHelloWorld
class does not create an array of figures with random and default parameters, as specified in the task description.
Please address these issues to ensure the code meets the core requirements and functions as expected. Keep up the great work, and don't hesitate to reach out if you need any help! 🌟
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
oop issues are fixed |
No description provided.