Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jv-oop-advanced task is done #1736

Conversation

serhii-slobodianiuk
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Thank you for your hard work on this project! 😊 It looks like there are a few critical issues that need to be addressed before we can approve the pull request. Here are the key areas that require attention:

  1. Implementation of Required Methods: Several classes, such as FigureSupplier, ColorSupplier, and the figure classes (Circle, Square, RightTriangle, Rectangle, IsoscelesTrapezoid), are missing essential methods for functionality like generating random figures and colors, calculating areas, and setting colors.

  2. Interface and Abstract Class Design: The AreaCalculator interface and Figure abstract class need to be properly designed to include methods for area calculation and color setting. The Drawable interface should also define a draw method.

  3. Enum and Class Structure: The Color enum is empty and should define constants for different colors. The class names and package structure should reflect their purpose and adhere to the task requirements.

  4. Main Class Functionality: The main() method in the HelloWorld class does not create an array of figures with random and default parameters, as specified in the task description.

Please address these issues to ensure the code meets the core requirements and functions as expected. Keep up the great work, and don't hesitate to reach out if you need any help! 🌟

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

src/main/java/core/basesyntax/Main.java Outdated Show resolved Hide resolved
src/main/java/core/basesyntax/Main.java Outdated Show resolved Hide resolved
src/main/java/core/basesyntax/Main.java Outdated Show resolved Hide resolved
src/main/java/core/basesyntax/Main.java Outdated Show resolved Hide resolved
src/main/java/core/basesyntax/Main.java Outdated Show resolved Hide resolved
src/main/java/core/basesyntax/service/AreaCalculator.java Outdated Show resolved Hide resolved
src/main/java/core/basesyntax/service/AreaCalculator.java Outdated Show resolved Hide resolved
src/main/java/core/basesyntax/service/Drawable.java Outdated Show resolved Hide resolved
@serhii-slobodianiuk
Copy link
Author

oop issues are fixed

@serhii-slobodianiuk serhii-slobodianiuk closed this by deleting the head repository Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants