Implemented a login method in AuthenticationService and findByEmail method in UserService #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethod in UserService
Elena-Bruyako
suggested changes
Oct 20, 2024
src/main/java/mate/academy/Main.java
Outdated
| @@ -3,6 +3,7 @@ | |||
| import mate.academy.service.AuthenticationService; | |||
|
|
|||
| public class Main { | |||
|
|
|||
| @@ -1,8 +1,9 @@ | |||
| package mate.academy.model; | |||
|
|
|||
| public class User { | |||
| private String email; | |||
| private String password; | |||
|
|
|||
| @@ -14,7 +15,13 @@ public class UserService { | |||
| * @return - user if his email is equal to passed email. | |||
| * Return <code>null</code> if there is no suitable user | |||
| */ | |||
| public User findByEmail(String email) { | |||
|
|
|||
| public static User findByEmail(String email) { | |||
There was a problem hiding this comment.
Suggested change
| public static User findByEmail(String email) { | |
| public User findByEmail(String email) { |
| public User findByEmail(String email) { | ||
|
|
||
| public static User findByEmail(String email) { | ||
| for (User person : users) { |
There was a problem hiding this comment.
Suggested change
| for (User person : users) { | |
| for (User user : users) { |
minor comment
| return false; | ||
| User user = UserService.findByEmail(email); | ||
|
|
||
| if (user == null) { |
okuzan
suggested changes
Oct 21, 2024
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| public class AuthenticationService { | |||
| /** | |||
| * Imagine that some user wants to login to your site. | |||
| * Imagine that some user wants to //login to your site. | |||
| @@ -11,6 +11,8 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| return false; | |||
| UserService userService = new UserService(); | |||
There was a problem hiding this comment.
create userService instance in class scope, not inside a method - we need only one per class instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ethod in UserService