integrated Rick and Morty API #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d1sam
suggested changes
Feb 13, 2024
| } | ||
|
|
||
| @GetMapping("/search") | ||
| @Operation(summary = "Search characters by name", description = "Search characters by name") |
There was a problem hiding this comment.
Suggested change
| @Operation(summary = "Search characters by name", description = "Search characters by name") | |
| @Operation(summary = "Search characters by name", description = "Search characters by name contains ignore case") |
| import org.springframework.data.domain.Pageable; | ||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
|
|
||
| public interface CharacterRepository extends JpaRepository<Character, Long> { |
There was a problem hiding this comment.
Suggested change
| public interface CharacterRepository extends JpaRepository<Character, Long> { | |
| @Repository | |
| public interface CharacterRepository extends JpaRepository<Character, Long> { |
|
|
||
| @Override | ||
| public CharacterDto findRandomCharacter() { | ||
| Long randomId = random.nextLong(characterRepository.count()) + 1; |
There was a problem hiding this comment.
it's not good idea to get count of characters from db during each findRandomCharacter method call. let's better to get this variable only once
vovasalyha
approved these changes
Feb 14, 2024
|
|
||
| @Override | ||
| public CharacterDto findRandomCharacter() { | ||
| Long randomId = random.nextLong(characterRepository.count()) + 1; | ||
| if (characterCount == null) { |
There was a problem hiding this comment.
Keep in mind that this method could be called by more than one parallel user, so better make characterCount field volatile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.