Implemented getRandom and getAllByNamePart methods #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vovasalyha
suggested changes
Feb 15, 2024
| @Configuration | ||
| public class AppConfig { | ||
| @Bean | ||
| public Random random() { |
There was a problem hiding this comment.
You don't need a bean of Random class. Also, in concurrent environments (web app is concurrent) it's preferred to use ThreadLocalRandom
| @RequestMapping("/characters") | ||
| @RequiredArgsConstructor | ||
| @Tag(name = "Characters management", | ||
| description = "Endpoints for managing characters from the Rick and Morty cartoon") |
There was a problem hiding this comment.
Usually managing means that the API allows some creation/modification, but this API is only for read access.
Suggested change
| description = "Endpoints for managing characters from the Rick and Morty cartoon") | |
| description = "Endpoints for retrieving characters from the Rick and Morty cartoon") |
| } | ||
|
|
||
| @GetMapping("/by-name") | ||
| @Operation(summary = "Get all characters by name part") |
There was a problem hiding this comment.
I would also specify that this search ignores case.
|
|
||
| @Override | ||
| public CharacterInternalDto getRandomCharacter() { | ||
| long randomId = random.nextLong(characterRepository.count()); |
There was a problem hiding this comment.
Think about optimizing this logic (considering that you save all characters only once on application startup)
vovasalyha
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.