First solution of jv-rick-and-morty #118
Conversation
| HttpResponse<String> response = httpClient.send( | ||
| request, HttpResponse.BodyHandlers.ofString()); | ||
|
|
||
| return objectMapper.readValue( | ||
| response.body(), CharacterResponseDataDto.class); | ||
|
|
There was a problem hiding this comment.
are you sure you receive all 826 characters with this implementation? Remember about pagination. You need some kind of a loop to check if there's a next page
| long randomId = random.nextLong(characterRepository.count()); | ||
| Character character = characterRepository.findById(randomId) | ||
| .orElseThrow(() -> | ||
| new RuntimeException("Cannot find a character by id: " + randomId)); |
There was a problem hiding this comment.
it's better to throw more specific exceptions where possible, let's go for EntityNotFound or NoSuchElement exception here
| @Query(value = "SELECT c FROM Character c WHERE c.name LIKE CONCAT('%', :name, '%')") | ||
| List<Character> findAllByNameContainingIgnoreCase(String name); |
There was a problem hiding this comment.
Consider removing the @query annotation for this method as Spring Data JPA's query derivation from method names can automatically generate the required query
| @@ -5,7 +5,6 @@ | |||
|
|
|||
| @SpringBootApplication | |||
| public class Application { | |||
|
|
|||
There was a problem hiding this comment.
Avoid unnecessary changes in your PRs.
| import lombok.Data; | ||
|
|
||
| @Data | ||
| public class CharacterExternalResponseDto { |
There was a problem hiding this comment.
You might use record instead of regular class for DTOs. Additionally, you won't require Lombok - @Data produces lots of boilerplate code.
| import lombok.Data; | ||
|
|
||
| @Data | ||
| public class CharacterResponseDataDto { |
| void contextLoads() { | ||
| } | ||
|
|
||
| @Test |
No description provided.