Home work #132
Open
Home work #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerrrusha
suggested changes
Mar 21, 2024
Comment on lines
24
to
39
| HttpClient httpClient = HttpClient.newHttpClient(); | ||
| HttpRequest httpRequest = HttpRequest.newBuilder() | ||
| .GET() | ||
| .uri(URI.create(url)) | ||
| .build(); | ||
| try { | ||
| HttpResponse<String> httpResponse = httpClient.send( | ||
| httpRequest, | ||
| HttpResponse.BodyHandlers.ofString()); | ||
| ApiResponseDto apiResponseDto = objectMapper | ||
| .readValue(httpResponse.body(), ApiResponseDto.class); | ||
| List<CharacterDtoFromApi> list = Arrays.stream(apiResponseDto.getResults()) | ||
| .map(characterMapper::toCharacterDtoForDb) | ||
| .toList(); | ||
| return apiResponseDto; | ||
| } catch (IOException | InterruptedException e) { |
There was a problem hiding this comment.
are you sure that you scrape all pages, not only the first one?
| import jakarta.persistence.Table; | ||
| import lombok.Data; | ||
|
|
||
| @Data |
There was a problem hiding this comment.
dont use data on entities as it cause bugs, use getter/setter instead
…cterMapper and CharacterDtoFromApi.class.Created Getters, Setters and toString methods in Character.class. Modified CharactersApiClient.class and CharacterServiceImpl.class.
kerrrusha
suggested changes
Mar 22, 2024
Comment on lines
23
to
31
| .GET() | ||
| .uri(new URI(url)) | ||
| .build(); | ||
| HttpResponse<String> httpResponse = httpClient.send( | ||
| httpRequest, | ||
| HttpResponse.BodyHandlers.ofString()); | ||
| return objectMapper | ||
| .readValue(httpResponse.body(), ApiResponseDto.class); | ||
| } catch (IOException | InterruptedException | URISyntaxException e) { |
| private final ObjectMapper objectMapper; | ||
| private final HttpClient httpClient = HttpClient.newHttpClient(); | ||
|
|
||
| public ApiResponseDto getAllCharacterFromApi(String url) { |
There was a problem hiding this comment.
better save this url somewhere here
Suggested change
| public ApiResponseDto getAllCharacterFromApi(String url) { | |
| public ApiResponseDto getAllCharacterFromApi() { |
…d /CharacterService.java, /CharacterServiceImpl.java and /CharactersApiClient.java.
MAMentorFX
approved these changes
Mar 23, 2024
|
|
||
| public static void main(String[] args) { | ||
| SpringApplication.run(Application.class, args); | ||
|
|
Comment on lines
+20
to
23
| @Bean | ||
| public CommandLineRunner commandLineRunner() { | ||
| return args -> characterService.saveCharactersToDb(); | ||
| } |
There was a problem hiding this comment.
Remember to move Bean initialisations into @configuration class
|
|
||
| @Component | ||
| public class CharacterMapper { | ||
| public CharacterResponseDto toResponseDto(Character character) { |
There was a problem hiding this comment.
be consistant with naming. It's either toCharacterResponseDto() and to Character() or toDto() and toModel()
Suggested change
| public CharacterResponseDto toResponseDto(Character character) { | |
| public CharacterResponseDto toDto(Character character) { |
|
|
||
| @Entity | ||
| @Table(name = "characters") | ||
| public class Character { |
There was a problem hiding this comment.
Suggested change
| public class Character { | |
| @Getter | |
| @Setter | |
| @ToString | |
| public class Character { |
| import org.springframework.data.domain.Pageable; | ||
|
|
||
| public interface CharacterService { | ||
|
|
| @RequiredArgsConstructor | ||
| @Service | ||
| public class CharacterServiceImpl implements CharacterService { | ||
|
|
| import org.springframework.stereotype.Component; | ||
|
|
||
| @Component | ||
| public class CharacterMapper { |
There was a problem hiding this comment.
Consider using MapStruct to remove all boiler code :)
Comment on lines
+35
to
+36
| @Override | ||
| public CharacterResponseDto getRandomCharacter() { |
There was a problem hiding this comment.
Suggested change
| @Override | |
| public CharacterResponseDto getRandomCharacter() { | |
| @Override | |
| @Transactional | |
| public CharacterResponseDto getRandomCharacter() { |
You have made two requests to db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.