Created API #133
Created API #133
Conversation
| @Tag(name = "Character management", description = "Endpoints for managing characters") | ||
| @RequiredArgsConstructor | ||
| @RestController | ||
| @RequestMapping("/character") |
There was a problem hiding this comment.
Better to use plural as endpoint represents that we have collection of characters
| @RequestMapping("/character") | |
| @RequestMapping("/characters") |
| @GetMapping("/by-name") | ||
| @Operation(summary = "Get characters by name", | ||
| description = "Returns a list of all characters with the given name") | ||
| public List<CharacterDto> getCharactersByName(@RequestParam String name) { |
There was a problem hiding this comment.
Filtering usually continues getAll operation. So .../characters is getAll and .../characters?name=someName is a filtered option, no need in additional URL suffix like .../characters/by-name?name=someNam
| @GetMapping("/by-name") | |
| @Operation(summary = "Get characters by name", | |
| description = "Returns a list of all characters with the given name") | |
| public List<CharacterDto> getCharactersByName(@RequestParam String name) { | |
| @GetMapping | |
| @Operation(summary = "Get characters by name", | |
| description = "Returns a list of all characters with the given name") | |
| public List<CharacterDto> getCharactersByName(@RequestParam String name) { |
| OriginResponseDto origin, | ||
| OriginResponseDto location, | ||
| String image, | ||
| ArrayList<String> episode, |
There was a problem hiding this comment.
No need to use particular List implementation
| ArrayList<String> episode, | |
| List<String> episode, |
| import java.util.ArrayList; | ||
|
|
||
| public record ResultsResponseDataDto( | ||
| ArrayList<CharacterResponseDataDto> results, |
There was a problem hiding this comment.
| ArrayList<CharacterResponseDataDto> results, | |
| List<CharacterResponseDataDto> results, |
|
|
||
| @RequiredArgsConstructor | ||
| @Component | ||
| public class SaveCharacters { |
There was a problem hiding this comment.
Verbs shouldn't be used in class names
| public class SaveCharacters { | |
| public class CharactersInitializer { |
| private final RickAndMortyClient rickAndMortyClient; | ||
|
|
||
| @PostConstruct | ||
| public void saveCharacters() { |
There was a problem hiding this comment.
method doesn't represent full specter of actions it's doing
| public void saveCharacters() { | |
| public void fetchCharactersToDb() { |
| public void saveCharacters() { | ||
| List<CharacterResponseDataDto> characterResponseDataDto = | ||
| rickAndMortyClient.getCharacters(); | ||
| characterService.saveAll(characterResponseDataDto); |
There was a problem hiding this comment.
I'd move logic from characterService.saveAll here.
It doesn't seems for me that work with characterResponseDataDto fits rest of methods characterService performs and may perform in future
No description provided.