implement get random character #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozhukhovsky
suggested changes
Mar 21, 2024
There was a problem hiding this comment.
We need to fix the build. And also, first, when you launch the application, you need to load all the characters into the database. And when accessing your controller, you should go to the database and pull out data, and not make a request to someone else’s API every time.
okuzan
approved these changes
Mar 22, 2024
| public class ExternalCharacterResponseDto { | ||
| private InfoResponseDto info; | ||
| private List<CharacterResponseDto> results; | ||
|
|
| @Override | ||
| public CharacterDto getRandomCharacterDto() { | ||
| long size = characterRepository.count(); | ||
| Random random = new Random(); |
There was a problem hiding this comment.
better to not recreate random once per method call, but once per class/instance creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.