Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Valdemar3X
Copy link

No description provided.

Copy link

@olekskov olekskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

</configuration>
</plugin>
</plugins>
</build>

</project>
</project>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line in the end

}

@Operation(summary = "Get list characters", description = "Get list characters by name from db")
@GetMapping("by-name")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filtered search is usually prolongation of getAll operation and doesn't require separate URL suffix

Suggested change
@GetMapping("by-name")
@GetMapping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants