added solution #148
Open
added solution #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olekskov
suggested changes
Apr 20, 2024
|
|
||
| @Bean | ||
| public ObjectMapper buildObjectMapper() { | ||
|
|
| public List<CharacterResponseDto> searchCharactersByName(@RequestParam String name) { | ||
| return characterService.findAllByName(name); | ||
| } | ||
| } |
Comment on lines
7
to
9
| @Data | ||
| @JsonIgnoreProperties(ignoreUnknown = true) | ||
| public class ThirdApiCharacterResponseDto { |
There was a problem hiding this comment.
having single DTO as class while others are records look strange
| CharacterResponseDataDto.class); | ||
| characterResponseDataDto.results().stream() | ||
| .map(characterMapper::toCharacter) | ||
| .forEach(characterRepository::save); |
There was a problem hiding this comment.
check if possible to use saveAll method to reduce amount of DB calls
Comment on lines
24
to
27
| @PostConstruct | ||
| public void loadDataToDb() { | ||
| rickAndMortyClient.loadDataToDb(); | ||
| } |
There was a problem hiding this comment.
This method doesn't look like it should be here
Suggested change
| @PostConstruct | |
| public void loadDataToDb() { | |
| rickAndMortyClient.loadDataToDb(); | |
| } |
| private final ObjectMapper objectMapper; | ||
| private final HttpClient httpClient; | ||
|
|
||
| public void loadDataToDb() { |
There was a problem hiding this comment.
Probably just
Suggested change
| public void loadDataToDb() { | |
| @PostConstruct | |
| public void loadDataToDb() { |
Comment on lines
31
to
32
| long count = characterRepository.count(); | ||
| Character character = characterRepository.findById(random.nextLong(count)) |
There was a problem hiding this comment.
Please check possibility to get single random record by using SQL query. It may you allow to fully get rid of Random object and simplify code
Rommelua
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.