-task solution/mark.1 #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerrrusha
suggested changes
May 17, 2024
Comment on lines
30
to
31
| public List<CharacterDto> getAllByName(@RequestParam String name) { | ||
| return service.getAllByName(name); |
There was a problem hiding this comment.
Suggested change
| public List<CharacterDto> getAllByName(@RequestParam String name) { | |
| return service.getAllByName(name); | |
| public List<CharacterDto> findAllByName(@RequestParam String name) { | |
| return service.findAllByName(name); |
Comment on lines
10
to
11
| @Data | ||
| @Entity |
There was a problem hiding this comment.
dont use data with entity as it cause bugs
Suggested change
| @Data | |
| @Entity | |
| @Getter | |
| @Setter | |
| @Entity |
Comment on lines
+37
to
+39
| HttpResponse<String> response = httpClient.send( | ||
| request, | ||
| HttpResponse.BodyHandlers.ofString()); |
There was a problem hiding this comment.
are you sure that you parse all pages, not the first one?
okuzan
approved these changes
May 19, 2024
| CharacterModel savedCharacterModel = repository.save(characterModel); | ||
| return mapper.toDto(savedCharacterModel); | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.