Implemented Rick and Morty app #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okuzan
suggested changes
Jul 12, 2024
pom.xml
Outdated
Comment on lines
16
to
28
| <url/> | ||
| <licenses> | ||
| <license/> | ||
| </licenses> | ||
| <developers> | ||
| <developer/> | ||
| </developers> | ||
| <scm> | ||
| <connection/> | ||
| <developerConnection/> | ||
| <tag/> | ||
| <url/> | ||
| </scm> |
| public class CharacterController { | ||
| private final CharacterService characterService; | ||
|
|
||
| @GetMapping("/search") |
There was a problem hiding this comment.
Suggested change
| @GetMapping("/search") | |
| @GetMapping |
that's more RESTful naming - we should focus on hierarchy of resources and avoid verbs. HTTP verbs should express the idea - GET is retrieving, searching
Comment on lines
18
to
19
| @SQLDelete(sql = "UPDATE books SET is_deleted = true WHERE id = ?") | ||
| @SQLRestriction(value = "is_deleted=false") |
There was a problem hiding this comment.
Suggested change
| @SQLDelete(sql = "UPDATE books SET is_deleted = true WHERE id = ?") | |
| @SQLRestriction(value = "is_deleted=false") | |
| @SQLDelete(sql = "UPDATE books SET is_deleted = TRUE WHERE id = ?") | |
| @SQLRestriction(value = "is_deleted = FALSE") |
| JpaSpecificationExecutor<Character> { | ||
| List<Character> findByNameContaining(String name); | ||
|
|
||
| @Query("from Character ORDER BY RAND() limit 1") |
There was a problem hiding this comment.
Suggested change
| @Query("from Character ORDER BY RAND() limit 1") | |
| @Query("FROM Character ORDER BY RAND() LIMIT 1") |
consistency is key, if you write some SQL keywords as uppercase - all of them should be uppercased
Comment on lines
25
to
28
| @Override | ||
| public List<CharacterResponseDto> findAllCharacters() { | ||
| HttpClient client = HttpClient.newHttpClient(); | ||
| HttpRequest request = HttpRequest.newBuilder() |
There was a problem hiding this comment.
you just get the first batch of 20 characters
Comment on lines
31
to
34
| return characterMapper.toDtoList( | ||
| characterRepository.findByNameContaining(name).stream() | ||
| .toList()); | ||
| } |
There was a problem hiding this comment.
just declare mapping list to list in the mapper, mapstruct supports this
MentorMateAcademy
suggested changes
Jul 13, 2024
| import org.springframework.data.jpa.repository.Query; | ||
| import org.springframework.stereotype.Repository; | ||
|
|
||
| @Repository |
There was a problem hiding this comment.
Suggested change
| @Repository |
sarakhmen
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.