task done, to review #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added: client connection get random character info get a character with string occurrence in the name
Ivan95kos
suggested changes
Oct 24, 2023
|
|
||
| @Component | ||
| @RequiredArgsConstructor | ||
| public class RickAndMortyClient { |
There was a problem hiding this comment.
All data from the public API should be fetched once, and only once, when the Application context is created
Comment on lines
23
to
24
| private static final String GET_CHAR_BASE_URL = "https://rickandmortyapi.com/api/character/%s"; | ||
| private static final String GET_ALL_BASE_URL = "https://rickandmortyapi.com/api/character"; |
There was a problem hiding this comment.
save the API in properties instead of constants
you can use
@Value("${rick-and-morty-api}")
private String url;
Ivan95kos
suggested changes
Oct 24, 2023
Comment on lines
33
to
39
| @Operation(summary = "saving all characters from client to db", | ||
| description = "save all char info from client db to yours," | ||
| + " only to use once for the first time with empty table") | ||
| @GetMapping("/save") | ||
| public void save() { | ||
| service.save(); | ||
| } |
There was a problem hiding this comment.
Anyone who finds this endpoint may spam external api on your behalf. Please do not leave such obvious vulnerabilities in code
use @PostConstruct in client service instead of endpoint /save
Suggested change
| @Operation(summary = "saving all characters from client to db", | |
| description = "save all char info from client db to yours," | |
| + " only to use once for the first time with empty table") | |
| @GetMapping("/save") | |
| public void save() { | |
| service.save(); | |
| } |
Rommelua
suggested changes
Oct 26, 2023
| @PostConstruct | ||
| public void save() { | ||
| List<Character> characters = new ArrayList<>(); | ||
| int pageAmount = 42; |
| @Override | ||
| public ExternalCharResponseDto getRandomCharacter() { | ||
| Random random = new Random(); | ||
| int maxCharAmount = 826; |
|
|
||
| @Override | ||
| @PostConstruct | ||
| public void save() { |
There was a problem hiding this comment.
Suggested change
| public void save() { | |
| public void saveCharactersFromPublicAPI() { |
kozhukhovsky
suggested changes
Oct 27, 2023
| public void save() { | ||
| List<Character> characters = repository.findAll(); | ||
| if (characters.isEmpty()) { | ||
| for (int i = 1; i < CLIENT_API_CHAR_TABLE_PAGE_NUMBER + 1; i++) { |
There was a problem hiding this comment.
What if the number of pages changes? No need to be tied to a fixed number. The code should work with any number of pages.
| public ExternalCharResponseDto getRandomCharacter() { | ||
| Random random = new Random(); | ||
| return mapper.toDto( | ||
| repository.findById(random.nextLong(CLIENT_API_TOTAL_CHAR_AMOUNT)) |
okuzan
approved these changes
Oct 30, 2023
| } | ||
|
|
||
| @Operation(summary = "show character by search name parameter", | ||
| description = "show character by string occurrence in his/her/its name") |
There was a problem hiding this comment.
Suggested change
| description = "show character by string occurrence in his/her/its name") | |
| description = "show character by string occurrence in their name") |
|
|
||
| @Override | ||
| public ExternalCharResponseDto getRandomCharacter() { | ||
| Random random = new Random(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added:
client connection
get random character info
get a character with string occurrence in the name