Solution #199
Open
Solution #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added @JsonIgnoreProperties annotation to CreateCharacterDto record; added character service;
added CharacterRepository;
-> refactoring phase
added swagger api;
- Added CharacterController with two endpoints: - GET /api/characters/random: Retrieves a random character from the database. - GET /api/characters/search: Searches for characters by name. - Introduced CharacterService for business logic and data management. - Integrated CharacterRepository for database access. - Implemented data fetching from the external Rick and Morty API during application startup. - Configured MySQL as the main database and H2 for testing. - Added Swagger documentation for API endpoints.
okuzan
suggested changes
Oct 24, 2024
| throw new HttpRequestException("Failed to send https request to url: " + url, e); | ||
| } | ||
| } | ||
|
|
| public List<CharacterDto> searchCharacters(@RequestParam String name) { | ||
| return characterService.searchCharactersByName(name); | ||
| } | ||
|
|
|
|
||
| @Configuration | ||
| public class ObjectMapperConfig { | ||
|
|
|
|
||
| @Entity | ||
| @Table(name = "characters") | ||
| @Data |
There was a problem hiding this comment.
Generally, avoid using Lombok's Data on JPA entities, it contains problematic EqualsAndHashcode and ToString, use Getter and Setter for now
| import org.mapstruct.Mapper; | ||
|
|
||
| @Mapper(config = MapperConfig.class) | ||
| public interface CharacterMapper { |
There was a problem hiding this comment.
FYI you can define List to List mapping here too to avoid mapping in stream chain
Comment on lines
23
to
30
| @GetMapping | ||
| public CharacterDto getRandomCharacter() { | ||
| return characterService.getRandomCharacter(); | ||
| } | ||
|
|
||
| @Operation(summary = "Search characters by name", | ||
| description = "Returns a list of characters matching the given name.") | ||
| @GetMapping("/search") |
There was a problem hiding this comment.
Suggested change
| @GetMapping | |
| public CharacterDto getRandomCharacter() { | |
| return characterService.getRandomCharacter(); | |
| } | |
| @Operation(summary = "Search characters by name", | |
| description = "Returns a list of characters matching the given name.") | |
| @GetMapping("/search") | |
| @GetMapping("/random") | |
| public CharacterDto getRandomCharacter() { | |
| return characterService.getRandomCharacter(); | |
| } | |
| @Operation(summary = "Search characters by name", | |
| description = "Returns a list of characters matching the given name.") | |
| @GetMapping |
it will be more RESTful (we generally avoid verbs in URL paths, HTTP verb should imply action)
liliia-ponomarenko
approved these changes
Oct 25, 2024
Comment on lines
+8
to
+13
| public class ObjectMapperConfig { | ||
| @Bean | ||
| public ObjectMapper objectMapper() { | ||
| return new ObjectMapper(); | ||
| } | ||
| } |
There was a problem hiding this comment.
you use one configuration file ;)
| ) | ||
| public class MapperConfig { | ||
| } | ||
|
|
|
|
||
| @Operation(summary = "Search characters by name", | ||
| description = "Returns a list of characters matching the given name.") | ||
| @GetMapping() |
There was a problem hiding this comment.
Suggested change
| @GetMapping() | |
| @GetMapping |
| import org.springframework.data.jpa.repository.JpaRepository; | ||
|
|
||
| public interface CharacterRepository extends JpaRepository<Character, Long> { | ||
| List<Character> findAllByNameIsContainingIgnoreCase(String name); |
There was a problem hiding this comment.
if I remember correctly mysql ignores case by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement REST API for Rick and Morty Characters
Added CharacterController with two endpoints:
Introduced CharacterService for business logic and data management.
Integrated CharacterRepository for database access.
Implemented data fetching from the external Rick and Morty API during application startup.
Configured MySQL as the main database and H2 for testing.
Added Swagger documentation for API endpoints.