result #204

ADIGrimm · 2024-11-11T20:44:14Z

No description provided.

mateacademy-ai-mentor

Great job! 🎉 Your implementation meets the task requirements and constraints effectively. The code is well-structured, and all necessary components are correctly configured. Just make sure to include Swagger documentation if it's required elsewhere in your project. Keep up the excellent work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Elena-Bruyako · 2024-11-12T11:16:34Z

src/main/java/mate/academy/rickandmorty/config/AppConfig.java

+public class AppConfig {
+
+    @Bean
+    public RestTemplate restTemplate() {


you actually don't need to create bean for RestTemplate by this way, so you can remove this config

Elena-Bruyako · 2024-11-12T11:20:24Z

src/main/java/mate/academy/rickandmorty/mapper/CharacterMapper.java

+
+@Component
+public class CharacterMapper {
+    public CharacterDto toDto(Character character) {


don't need to implement mapping by yourself, use MapStruct

Elena-Bruyako · 2024-11-12T11:20:41Z

src/main/java/mate/academy/rickandmorty/model/Character.java

+    @Id
+    @GeneratedValue(strategy = GenerationType.IDENTITY)
+    private Long id;
+    private String internalId;


Suggested change

private String internalId;

@Column(nullable = false, unique = true)

private String internalId;

Elena-Bruyako · 2024-11-12T11:21:41Z

src/main/java/mate/academy/rickandmorty/service/impl/CharacterServiceImpl.java

+
+    @Override
+    public List<ApiDto> fetchAllCharacters() {
+        String url = "https://rickandmortyapi.com/api/character?page=";


it's better to use class-level variable for url
Also, you can use @Value and add url to app properties

Elena-Bruyako · 2024-11-12T11:25:06Z

src/main/java/mate/academy/rickandmorty/dto/ApiDto.java

+import lombok.Data;
+
+@Data
+public class ApiDto {


For this task such Dto will be enough

Example,

public record CharacterResponseDto( Map<String, Object> info, List<CharacterExternalDto> results) { } public record CharacterExternalDto( Long id, String name, String status, String gender) { } public record CharacterDto( Long id, Long externalId, String name, String status, String gender ) {}

ahoienko

Nice, left some comments

ahoienko · 2024-11-12T16:14:54Z

pom.xml

+			<artifactId>mysql-connector-j</artifactId>
+			<scope>runtime</scope>
+		</dependency>
+


Suggested change

ahoienko · 2024-11-12T16:15:02Z

pom.xml

+			<groupId>org.springframework</groupId>
+			<artifactId>spring-web</artifactId>
+		</dependency>
+


Suggested change

ahoienko · 2024-11-12T16:15:54Z

src/main/java/mate/academy/rickandmorty/mapper/CharacterMapper.java

+    Character toEntity(CharacterExternalDto characterResponseDto);
+
+    default String generateInternalId(CharacterExternalDto dto) {
+        return dto.getId() != null ? String.valueOf(dto.getId()) : "default-id";


Suggested change

return dto.getId() != null ? String.valueOf(dto.getId()) : "default-id";

return dto.getId() != null ? String.valueOf(dto.getId()) : DEFAULT_ID;

Not resolved

ahoienko · 2024-11-12T16:16:16Z

src/main/java/mate/academy/rickandmorty/service/impl/CharacterServiceImpl.java

+    public static final String URL = "https://rickandmortyapi.com/api/character?page=";
+    public static final Long CHARACTER_MAX = 826L;


Suggested change

public static final String URL = "https://rickandmortyapi.com/api/character?page=";

public static final Long CHARACTER_MAX = 826L;

private static final String URL = "https://rickandmortyapi.com/api/character?page=";

private static final Long CHARACTER_MAX = 826L;

Not resolved

ahoienko · 2024-11-12T16:16:43Z

src/main/java/mate/academy/rickandmorty/service/impl/CharacterServiceImpl.java

+
+    @Override
+    public CharacterDto getRandomCharacter() {
+        Random random = new Random();


What is the reason to create this object each time method is called?

Not resolved

ahoienko · 2024-11-12T16:17:54Z

src/main/java/mate/academy/rickandmorty/service/impl/CharacterServiceImpl.java

+        List<CharacterExternalDto> allCharacters = new ArrayList<>();
+        int page = 1;
+        CharacterResponseDto response;
+        do {
+            ResponseEntity<CharacterResponseDto> apiResponse = restTemplate
+                    .getForEntity(URL + page, CharacterResponseDto.class);
+            response = apiResponse.getBody();
+            if (response != null && response.getResults() != null) {
+                allCharacters.addAll(response.getResults());
+            }
+            String nextPageUrl = (String) response.getInfo().get("next");
+            page++;
+        } while (response != null && response.getInfo().get("next") != null);
+        return allCharacters;


move string literals to constants

Not resolved

ahoienko · 2024-11-12T16:19:00Z

src/main/java/mate/academy/rickandmorty/service/impl/CharacterServiceImpl.java

+        List<CharacterExternalDto> allCharacters = new ArrayList<>();
+        int page = 1;
+        CharacterResponseDto response;
+        do {
+            ResponseEntity<CharacterResponseDto> apiResponse = restTemplate
+                    .getForEntity(URL + page, CharacterResponseDto.class);
+            response = apiResponse.getBody();
+            if (response != null && response.getResults() != null) {
+                allCharacters.addAll(response.getResults());
+            }
+            String nextPageUrl = (String) response.getInfo().get("next");
+            page++;
+        } while (response != null && response.getInfo().get("next") != null);
+        return allCharacters;


Add some line breaks

Not resolved

ahoienko · 2024-11-12T16:23:05Z

src/main/java/mate/academy/rickandmorty/service/impl/CharacterServiceImpl.java

+        return allCharacters;
+    }
+
+    @PostConstruct


PostConstruct annotation is used to indicate 'init' method, the porpose of init method is to configure something in bean, code that you wrote here has nothing to deal with bean configuration. If you want to make some operation on program start please check ApplicationReadyEvent or use CommandLineRunner

Not resolved

ahoienko · 2024-11-12T16:23:17Z

src/main/resources/db/changelog/db.changelog-master.yaml

@@ -0,0 +1,3 @@
+databaseChangeLog:
+  - include:
+      file: db/changelog/changes/01-create-characters-table.yaml


Suggested change

file: db/changelog/changes/01-create-characters-table.yaml

file: db/changelog/changes/01-create-characters-table.yaml

Not resolved

added/removed lines in CharacterServiceImpl, db.changelog-master, pom added constants in CharacterServiceImpl, CharacterMapper

ahoienko

Please resolve comments before pushing new solution

ahoienko · 2024-11-13T09:43:52Z

src/main/java/mate/academy/rickandmorty/mapper/CharacterMapper.java

+    Character toEntity(CharacterExternalDto characterResponseDto);
+
+    default String generateInternalId(CharacterExternalDto dto) {
+        return dto.getId() != null ? String.valueOf(dto.getId()) : "default-id";


Not resolved

ahoienko · 2024-11-13T09:44:03Z

src/main/java/mate/academy/rickandmorty/service/impl/CharacterServiceImpl.java

+    public static final String URL = "https://rickandmortyapi.com/api/character?page=";
+    public static final Long CHARACTER_MAX = 826L;


Not resolved

ahoienko · 2024-11-13T09:44:09Z

src/main/java/mate/academy/rickandmorty/service/impl/CharacterServiceImpl.java

+
+    @Override
+    public CharacterDto getRandomCharacter() {
+        Random random = new Random();


Not resolved

ahoienko · 2024-11-13T09:44:13Z

src/main/java/mate/academy/rickandmorty/service/impl/CharacterServiceImpl.java

+        List<CharacterExternalDto> allCharacters = new ArrayList<>();
+        int page = 1;
+        CharacterResponseDto response;
+        do {
+            ResponseEntity<CharacterResponseDto> apiResponse = restTemplate
+                    .getForEntity(URL + page, CharacterResponseDto.class);
+            response = apiResponse.getBody();
+            if (response != null && response.getResults() != null) {
+                allCharacters.addAll(response.getResults());
+            }
+            String nextPageUrl = (String) response.getInfo().get("next");
+            page++;
+        } while (response != null && response.getInfo().get("next") != null);
+        return allCharacters;


Not resolved

ahoienko · 2024-11-13T09:44:16Z

src/main/java/mate/academy/rickandmorty/service/impl/CharacterServiceImpl.java

+        return allCharacters;
+    }
+
+    @PostConstruct


Not resolved

ahoienko · 2024-11-13T09:44:18Z

src/main/java/mate/academy/rickandmorty/service/impl/CharacterServiceImpl.java

+        List<CharacterExternalDto> allCharacters = new ArrayList<>();
+        int page = 1;
+        CharacterResponseDto response;
+        do {
+            ResponseEntity<CharacterResponseDto> apiResponse = restTemplate
+                    .getForEntity(URL + page, CharacterResponseDto.class);
+            response = apiResponse.getBody();
+            if (response != null && response.getResults() != null) {
+                allCharacters.addAll(response.getResults());
+            }
+            String nextPageUrl = (String) response.getInfo().get("next");
+            page++;
+        } while (response != null && response.getInfo().get("next") != null);
+        return allCharacters;


Not resolved

ahoienko · 2024-11-13T09:44:21Z

src/main/resources/db/changelog/db.changelog-master.yaml

@@ -0,0 +1,3 @@
+databaseChangeLog:
+  - include:
+      file: db/changelog/changes/01-create-characters-table.yaml


Not resolved

ADIGrimm · 2024-11-13T18:10:11Z

Sorry, I forgot to push

result

b66427a

mateacademy-ai-mentor approved these changes Nov 11, 2024

View reviewed changes

Elena-Bruyako suggested changes Nov 12, 2024

View reviewed changes

fixed

29986c5

ADIGrimm requested a review from Elena-Bruyako November 12, 2024 16:12

ahoienko suggested changes Nov 12, 2024

View reviewed changes

fixed

5f9f508

added/removed lines in CharacterServiceImpl, db.changelog-master, pom added constants in CharacterServiceImpl, CharacterMapper

ADIGrimm requested a review from ahoienko November 12, 2024 22:28

ahoienko suggested changes Nov 13, 2024

View reviewed changes

ADIGrimm requested a review from ahoienko November 13, 2024 18:10

Elena-Bruyako approved these changes Nov 14, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

result #204

result #204

ADIGrimm commented Nov 11, 2024

mateacademy-ai-mentor left a comment

Elena-Bruyako Nov 12, 2024

Elena-Bruyako Nov 12, 2024

Elena-Bruyako Nov 12, 2024

Elena-Bruyako Nov 12, 2024

Elena-Bruyako Nov 12, 2024

ahoienko left a comment

ahoienko Nov 12, 2024

ahoienko Nov 12, 2024

ahoienko Nov 12, 2024

ahoienko Nov 13, 2024

ahoienko Nov 12, 2024

ahoienko Nov 13, 2024

ahoienko Nov 12, 2024

ahoienko Nov 13, 2024

ahoienko Nov 12, 2024

ahoienko Nov 13, 2024

ahoienko Nov 12, 2024

ahoienko Nov 13, 2024

ahoienko Nov 12, 2024

ahoienko Nov 13, 2024

ahoienko Nov 12, 2024

ahoienko Nov 13, 2024

ahoienko left a comment

ahoienko Nov 13, 2024

ahoienko Nov 13, 2024

ahoienko Nov 13, 2024

ahoienko Nov 13, 2024

ahoienko Nov 13, 2024

ahoienko Nov 13, 2024

ahoienko Nov 13, 2024

ADIGrimm commented Nov 13, 2024

	private String internalId;
	@Column(nullable = false, unique = true)
	private String internalId;

	return dto.getId() != null ? String.valueOf(dto.getId()) : "default-id";
	return dto.getId() != null ? String.valueOf(dto.getId()) : DEFAULT_ID;

		public static final String URL = "https://rickandmortyapi.com/api/character?page=";
		public static final Long CHARACTER_MAX = 826L;

	file: db/changelog/changes/01-create-characters-table.yaml
	file: db/changelog/changes/01-create-characters-table.yaml

result #204

Are you sure you want to change the base?

result #204

Conversation

ADIGrimm commented Nov 11, 2024

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ahoienko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ahoienko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ADIGrimm commented Nov 13, 2024