-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add personage management functionality #205
base: main
Are you sure you want to change the base?
Conversation
Introduced core classes, services, and configurations necessary for handling personages in the application. Includes creating, updating, retrieving, and deleting personages, as well as exception handling and data loading integrations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the task requirements! 🎉 The code is well-structured and meets the core functionality. Just a small typo to fix: ensure the method name is toModelFromMetaData
for consistency. Keep up the excellent work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
return args -> { | ||
List<PersonageDataDto> charactersData = personageClient.fetchPersonages(); | ||
List<Personage> personages = charactersData.stream() | ||
.map(personageMapper::toModelFromMeteData) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the method reference personageMapper::toModelFromMeteData
. It should be personageMapper::toModelFromMetaData
to match the method name in the PersonageMapper
interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Personage toModel(CreatePersonageRequestDto requestDto); | ||
|
||
@Mapping(target = "externalId", source = "id") | ||
Personage toModelFromMeteData(PersonageDataDto dataDto); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the method name toModelFromMeteData
. It should be toModelFromMetaData
to maintain consistency and avoid errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Introduced core classes, services, and configurations necessary for handling personages in the application. Includes creating, updating, retrieving, and deleting personages, as well as exception handling and data loading integrations.