added integration with rick-and-morty API #4
Conversation
pom.xml
Outdated
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-devtools</artifactId> | ||
| <scope>runtime</scope> | ||
| <optional>true</optional> |
| public record CharacterInfoDto( | ||
| @JsonProperty("id") Long externalId, String name, String status, String gender |
There was a problem hiding this comment.
weird formatting:
| public record CharacterInfoDto( | |
| @JsonProperty("id") Long externalId, String name, String status, String gender | |
| public record CharacterInfoDto( | |
| @JsonProperty("id") | |
| Long externalId, | |
| String name, | |
| String status, | |
| String gender |
|
|
||
| import java.util.List; | ||
|
|
||
| public record CharacterResponseDto( |
There was a problem hiding this comment.
a general recommendation on record formatting
if your record has 1-2 fields, you can:
public record SomeRecord(String field1, Integer field2) {
if your record has more than 2 fields:
public record SomeRecord(String field1,
int field2,
Double field3,
boolean field4) {
or alrternative:
public record SomeRecord(
String field1,
int field2,
Double field3,
boolean field4) {
| @Column(nullable = false) | ||
| private Long externalId; |
|
|
||
| @Service | ||
| public class CharactersClientService { | ||
| private static final String BASE_URL = "https://rickandmortyapi.com/api/character"; |
There was a problem hiding this comment.
this can be stored in your app properties, and then be injected here via @Value
| @Service | ||
| public class CharactersClientService { | ||
| private static final String BASE_URL = "https://rickandmortyapi.com/api/character"; | ||
| private final HttpClient httpClient = HttpClient.newHttpClient(); |
There was a problem hiding this comment.
consider defining it as a bean
also you may find using RestTemplate easier
| public class CharactersClientService { | ||
| private static final String BASE_URL = "https://rickandmortyapi.com/api/character"; | ||
| private final HttpClient httpClient = HttpClient.newHttpClient(); | ||
| private final ObjectMapper objectMapper = new ObjectMapper(); |
There was a problem hiding this comment.
web starter already brings autoconfiguration, that has a bean of ObjectMapper - no need to create additional one
| import org.springframework.stereotype.Service; | ||
|
|
||
| @Service | ||
| public class CharactersClientService { |
There was a problem hiding this comment.
may be simplified to CharactersClient
| } | ||
| return characters; | ||
| } catch (URISyntaxException | IOException | InterruptedException e) { | ||
| throw new RuntimeException("Retrieving characters failed", e); |
There was a problem hiding this comment.
consider creating your custom exception
|
|
||
| @Override | ||
| public CharacterDto getRandomCharacter() { | ||
| List<Character> characters = characterRepository.findAll(); |
There was a problem hiding this comment.
this is a bit incorrect
you need to get a random character, however you load all the characters from the DB
think of how you can load only 1 random character via repository :)
There was a problem hiding this comment.
I don't have an idea how to do this in one SQL query, so I thought of using a random page with a size=1
|
|
||
| @Override | ||
| public List<CharacterDto> searchCharacters( | ||
| String name, @PageableDefault(size = 5, sort = "id") Pageable pageable) { |
There was a problem hiding this comment.
there is no need to use @PageableDefault here
No description provided.