add solution #4297
Open
add solution #4297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 10, 2024 18:47
Esceype
suggested changes
Apr 10, 2024
src/styles/card.scss
Outdated
Comment on lines
11
to
28
| @keyframes scale { | ||
| 100% { | ||
| transform: scale(1.2); | ||
| } | ||
| } | ||
|
|
||
| @keyframes title-color { | ||
| 100% { | ||
| color: #34568b; | ||
| } | ||
| } | ||
|
|
||
| @keyframes button-change { | ||
| 100% { | ||
| background-color: #fff; | ||
| color: $button-color; | ||
| } | ||
| } |
There was a problem hiding this comment.
Use transition instead of all these animations
src/index.html
Outdated
Comment on lines
116
to
121
| /> | ||
| <h2 class="card__name-panel"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
| <p class="card__product-code">Product code: 195434</p> | ||
| <div class="card__review"> |
There was a problem hiding this comment.
Suggested change
| /> | |
| <h2 class="card__name-panel"> | |
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | |
| </h2> | |
| <p class="card__product-code">Product code: 195434</p> | |
| <div class="card__review"> | |
| /> | |
| <h2 class="card__name-panel"> | |
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | |
| </h2> | |
| <p class="card__product-code">Product code: 195434</p> | |
| <div class="card__review"> |
src/styles/header.scss
Outdated
| border-radius: 8px; | ||
| } | ||
|
|
||
| @keyframes nav-color { |
| margin-bottom: 4px; | ||
| } | ||
|
|
||
| &:hover { |
There was a problem hiding this comment.
This hover effect should be smooth for both cases when mouse enter on element and when it leaves
src/styles/header.scss
Outdated
| height: 40px; | ||
| } | ||
|
|
||
| &__nav { |
There was a problem hiding this comment.
Nav should be a separate BEM block so please make it and move to a separate file since it is block
|
fixes applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK
All component follow BEM and use SCSS
repaeted sizes and special colors are put to variables
Grid is used for the columns
cards are shown in 1, 2, 3 or 4 columns based on screen resolution
All changes on
:hoverare smoothCode follows all the Code Style Rules ❗️