Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #4797

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

add task solution #4797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bf86d9e
add task solution
yurzxw Oct 23, 2024
af11854
add task solution
yurzxw Oct 27, 2024
94f6b21
add task solution
yurzxw Oct 27, 2024
eb3bfea
add task solution
yurzxw Oct 27, 2024
ff70c88
Merge branch 'master' into develop
yurzxw Oct 27, 2024
88daf58
add task solution
yurzxw Oct 27, 2024
5ce6709
add task solution
yurzxw Oct 31, 2024
bd5e138
add task solution
yurzxw Nov 2, 2024
57e8c4c
add task solution
yurzxw Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Create HTML page with catalog. Develop semantic page structure as shown on [the
- add `data-qa="card-hover"` (not just `hover`) to the link `Buy` inside the first card
- nav links color is not `black` any more (nav links should have `#060b35` color)
- add class `is-active` to the first link (`Apple`) in navigation
- use `<main>` tag for cards container
- use `<main>` tag for cards container
- use grid for cards with different number of columns:
- 1 for the smaller screens
- 2 starting at `488px`
Expand All @@ -32,8 +32,8 @@ Make all the changes smooth on hover (during 300ms):
## Checklist

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:
- [DEMO LINK](https://<your_account>.github.io/layout_catalog/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_catalog/report/html_report/)
- [DEMO LINK](https://yurzxw.github.io/layout_catalog/)
- [TEST REPORT LINK](https://yurzxw.github.io/layout_catalog/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
368 changes: 367 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,372 @@
</head>

<body>
<h1>Catalog</h1>
<header class="header">
<a
href="#"
class="moyo"
>
<img
src="./images/logo.png"
alt="Moyo"
/>
</a>
Comment on lines +26 to +34
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The anchor tag has an href attribute set to '#', which might not be functional. Ensure that this is intentional or replace it with a valid URL if needed.

<nav class="nav">
<ul class="nav__list">
<li class="nav__item">
<a
href="#"
class="nav__link is-active"
>
Apple
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
Samsung
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
Smartphones
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
data-qa="nav-hover"
>
Laptops & Computers
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
Gadgets
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
Tablets
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
Photo
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link video"
>
Video
</a>
</li>
</ul>
</nav>
</header>
<main class="catalog">
<div
class="card"
data-qa="card-hover"
>
<img
src="../src/images/imac.jpeg"
class="card_imac"
alt="iMac"
/>
<p class="card_name">
APPLE A1419 iMac 27" Retina
<br />
5K Monoblock (MNED2UA/A)
</p>
<p class="card_code">Product code: 195434</p>
<div class="card_reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card_comments">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-label">Price:</p>
<p class="card__price-value">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
buy
</a>
</div>
<div
class="card"
data-qa="card"
>
<img
src="../src/images/imac.jpeg"
class="card_imac"
alt="iMac"
/>
<p class="card_name">
APPLE A1419 iMac 27" Retina
<br />
5K Monoblock (MNED2UA/A)
</p>
<p class="card_code">Product code: 195434</p>
<div class="card_reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card_comments">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-label">Price:</p>
<p class="card__price-value">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
buy
</a>
</div>
<div
class="card"
data-qa="card"
>
<img
src="../src/images/imac.jpeg"
class="card_imac"
alt="iMac"
/>
<p class="card_name">
APPLE A1419 iMac 27" Retina
<br />
5K Monoblock (MNED2UA/A)
</p>
<p class="card_code">Product code: 195434</p>
<div class="card_reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card_comments">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-label">Price:</p>
<p class="card__price-value">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
buy
</a>
</div>
<div
class="card"
data-qa="card"
>
<img
src="../src/images/imac.jpeg"
class="card_imac"
alt="iMac"
/>
<p class="card_name">
APPLE A1419 iMac 27" Retina
<br />
5K Monoblock (MNED2UA/A)
</p>
<p class="card_code">Product code: 195434</p>
<div class="card_reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card_comments">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-label">Price:</p>
<p class="card__price-value">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
buy
</a>
</div>
<div
Comment on lines +249 to +250
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the blank line between the cards

Suggested change
</div>
<div
</div>
<div

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not fixed.

class="card"
data-qa="card"
>
<img
src="../src/images/imac.jpeg"
class="card_imac"
alt="iMac"
/>
<p class="card_name">
APPLE A1419 iMac 27" Retina
<br />
5K Monoblock (MNED2UA/A)
</p>
<p class="card_code">Product code: 195434</p>
<div class="card_reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card_comments">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-label">Price:</p>
<p class="card__price-value">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
buy
</a>
</div>
<div
class="card"
data-qa="card"
>
<img
src="../src/images/imac.jpeg"
class="card_imac"
alt="iMac"
/>
<p class="card_name">
APPLE A1419 iMac 27" Retina
<br />
5K Monoblock (MNED2UA/A)
</p>
<p class="card_code">Product code: 195434</p>
<div class="card_reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card_comments">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-label">Price:</p>
<p class="card__price-value">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
buy
</a>
</div>
<div
class="card"
data-qa="card"
>
<img
src="../src/images/imac.jpeg"
class="card_imac"
alt="iMac"
/>
<p class="card_name">
APPLE A1419 iMac 27" Retina
<br />
5K Monoblock (MNED2UA/A)
</p>
<p class="card_code">Product code: 195434</p>
<div class="card_reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card_comments">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-label">Price:</p>
<p class="card__price-value">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
buy
</a>
</div>
<div class="card">
<img
src="../src/images/imac.jpeg"
class="card_imac"
alt="iMac"
/>
<p class="card_name">
APPLE A1419 iMac 27" Retina
<br />
5K Monoblock (MNED2UA/A)
</p>
<p class="card_code">Product code: 195434</p>
<div class="card_reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card_comments">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-label">Price:</p>
<p class="card__price-value">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
buy
</a>
</div>
</main>
</body>
</html>
Loading
Loading