done #4812
Open
done #4812
+656
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etojeDenys
suggested changes
Oct 28, 2024
etojeDenys
approved these changes
Oct 29, 2024
Comment on lines
+1
to
+16
| .stars { | ||
| display: flex; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .stars__star { | ||
| width: 16px; | ||
| height: 16px; | ||
| background-position: center; | ||
| background-repeat: no-repeat; | ||
| background-image: url(../images/star.svg); | ||
| } | ||
|
|
||
| .stars__star:not(:last-child) { | ||
| margin-right: 4px; | ||
| } |
There was a problem hiding this comment.
rewrite it using the sass nesting (&__)
|
|
||
| @media (min-width: 488px) { | ||
| grid-template-columns: repeat(2, 200px); | ||
| grid-template-rows: repeat(2, 1fr); |
There was a problem hiding this comment.
you don't need to repeat this line in all media queries
|
|
||
| @media (min-width: 768px) { | ||
| grid-template-columns: repeat(3, 200px); | ||
| grid-template-rows: repeat(2, 1fr); |
|
|
||
| @media (min-width: 1024px) { | ||
| grid-template-columns: repeat(4, 200px); | ||
| grid-template-rows: repeat(2, 1fr); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
❗️ Replace <your_account> with your Github username and copy the links to Pull Request description:
DEMO LINK
TEST REPORT LINK
[x]All component follow BEM and use SCSS
[x]repaeted sizes and special colors are put to variables
[x]Grid is used for the columns
[x]cards are shown in 1, 2, 3 or 4 columns based on screen resolution
[x]All changes on :hover are smooth
[x]Code follows all the Code Style Rules ❗️