-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #4821
base: master
Are you sure you want to change the base?
Develop #4821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on your work! 🎉 The code is well-structured and meets the core requirements of the task. There are a couple of minor issues, like the typo in the variable name $font-size-standart
and the duplicate font links in the HTML file. These don't impact the functionality but addressing them will enhance the maintainability and performance of your project. Keep up the good work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<link | ||
rel="preconnect" | ||
href="https://fonts.googleapis.com" | ||
/> | ||
<link | ||
rel="preconnect" | ||
href="https://fonts.gstatic.com" | ||
crossorigin="anonymous" | ||
/> | ||
<link | ||
href="https://fonts.googleapis.com/css2?family=Roboto:wght@400;500;700;900&display=swap" | ||
rel="stylesheet" | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are duplicate <link>
elements for preconnecting to Google Fonts and loading the Roboto font. Consider removing the redundant links to optimize loading performance and reduce unnecessary HTTP requests. You can consolidate the font loading to a single set of <link>
elements.
$gray: #616070; | ||
$white: #fff; | ||
$blue-black: #34568b; | ||
$font-size-standart: 12px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the variable name $font-size-standart
. It should be $font-size-standard
to correctly reflect the intended meaning.
:hover
are smooth