Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #4821

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Develop #4821

wants to merge 3 commits into from

Conversation

staner1
Copy link

@staner1 staner1 commented Oct 31, 2024

  • DEMO LINK
  • TEST REPORT LINK
  • All component follow BEM and use SCSS
  • repaeted sizes and special colors are put to variables
  • Grid is used for the columns
  • cards are shown in 1, 2, 3 or 4 columns based on screen resolution
  • All changes on :hover are smooth
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your work! 🎉 The code is well-structured and meets the core requirements of the task. There are a couple of minor issues, like the typo in the variable name $font-size-standart and the duplicate font links in the HTML file. These don't impact the functionality but addressing them will enhance the maintainability and performance of your project. Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +25 to +37
<link
rel="preconnect"
href="https://fonts.googleapis.com"
/>
<link
rel="preconnect"
href="https://fonts.gstatic.com"
crossorigin="anonymous"
/>
<link
href="https://fonts.googleapis.com/css2?family=Roboto:wght@400;500;700;900&display=swap"
rel="stylesheet"
/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are duplicate <link> elements for preconnecting to Google Fonts and loading the Roboto font. Consider removing the redundant links to optimize loading performance and reduce unnecessary HTTP requests. You can consolidate the font loading to a single set of <link> elements.

$gray: #616070;
$white: #fff;
$blue-black: #34568b;
$font-size-standart: 12px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the variable name $font-size-standart. It should be $font-size-standard to correctly reflect the intended meaning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants