Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #4831

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #4831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e35adb7
add task solution
nikovod Nov 7, 2024
80b3c9e
explicitly mention margin instead of "inherit"
nikovod Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Create an HTML page with a catalog. Develop semantic page structure as shown on
- add `data-qa="card-hover"` (not just `hover`) to the link `Buy` inside the first card
- nav links color is not `black` anymore (nav links should have `#060b35` color)
- add the class `is-active` to the first link (`Apple`) in the navigation
- use `<main>` tag for cards container
- use `<main>` tag for cards container
- use the grid for cards with different numbers of columns:
- 1 for the smaller screens
- 2 starting at `488px`
Expand All @@ -33,14 +33,14 @@ This is possible because [we use the Parcel library](https://en.parceljs.org/scs
## Checklist

❗️ Replace `<your_account>` with your GitHub username and copy the links to the `Pull Request` description:
- [DEMO LINK](https://<your_account>.github.io/layout_catalog/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_catalog/report/html_report/)
- [DEMO LINK](https://nikovod.github.io/layout_catalog/)
- [TEST REPORT LINK](https://nikovod.github.io/layout_catalog/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

- [ ] All components follow BEM and use SCSS
- [ ] Repeated sizes and special colors are put to variables
- [ ] Grid is used for the columns
- [ ] Cards are shown in 1, 2, 3, or 4 columns based on screen resolution
- [ ] All changes on `:hover` are smooth
- [ ] Code follows all the [Code Style Rules ❗️](https://mate-academy.github.io/layout_task-guideline/html-css-code-style-rules)
- [x] All components follow BEM and use SCSS
- [x] Repeated sizes and special colors are put to variables
- [x] Grid is used for the columns
- [x] Cards are shown in 1, 2, 3, or 4 columns based on screen resolution
- [x] All changes on `:hover` are smooth
- [x] Code follows all the [Code Style Rules ❗️](https://mate-academy.github.io/layout_task-guideline/html-css-code-style-rules)
351 changes: 350 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,355 @@
</head>

<body>
<h1>Catalog</h1>
<header class="header">
<a
href="index.html"
class="header__logo-link"
>
<img
src="images/logo.png"
alt="Moyo logo"
/>
</a>

<nav class="nav">
<ul class="nav__list">
<li>
<a
class="nav__link is-active"
href="index.html"
Comment on lines +39 to +41
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links point to 'index.html'. If these links are intended to navigate to different pages, ensure the 'href' attributes are updated accordingly.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute for this navigation link is set to 'index.html'. Ensure this is the correct link for the 'Apple' section. If not, update it to the correct URL.

>
Apple
</a>
</li>

<li>
<a
class="nav__link"
href="index.html"
Comment on lines +48 to +50
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links point to 'index.html'. If these links are intended to navigate to different pages, ensure the 'href' attributes are updated accordingly.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute for this navigation link is set to 'index.html'. Ensure this is the correct link for the 'Samsung' section. If not, update it to the correct URL.

>
Samsung
</a>
</li>

<li>
<a
class="nav__link"
href="index.html"
Comment on lines +57 to +59
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links point to 'index.html'. If these links are intended to navigate to different pages, ensure the 'href' attributes are updated accordingly.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute for this navigation link is set to 'index.html'. Ensure this is the correct link for the 'Smartphones' section. If not, update it to the correct URL.

>
Smartphones
</a>
</li>

<li>
<a
class="nav__link"
href="index.html"
Comment on lines +66 to +68
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links point to 'index.html'. If these links are intended to navigate to different pages, ensure the 'href' attributes are updated accordingly.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute for this navigation link is set to 'index.html'. Ensure this is the correct link for the 'Laptops & Computers' section. If not, update it to the correct URL.

data-qa="nav-hover"
>
Laptops & Computers
</a>
</li>

<li>
<a
class="nav__link"
href="index.html"
Comment on lines +76 to +78
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links point to 'index.html'. If these links are intended to navigate to different pages, ensure the 'href' attributes are updated accordingly.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute for this navigation link is set to 'index.html'. Ensure this is the correct link for the 'Gadgets' section. If not, update it to the correct URL.

>
Gadgets
</a>
</li>

<li>
<a
class="nav__link"
href="index.html"
Comment on lines +85 to +87
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links point to 'index.html'. If these links are intended to navigate to different pages, ensure the 'href' attributes are updated accordingly.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute for this navigation link is set to 'index.html'. Ensure this is the correct link for the 'Tablets' section. If not, update it to the correct URL.

>
Tablets
</a>
</li>

<li>
<a
class="nav__link"
href="index.html"
Comment on lines +94 to +96
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links point to 'index.html'. If these links are intended to navigate to different pages, ensure the 'href' attributes are updated accordingly.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute for this navigation link is set to 'index.html'. Ensure this is the correct link for the 'Photo' section. If not, update it to the correct URL.

>
Photo
</a>
</li>

<li>
<a
class="nav__link"
href="index.html"
Comment on lines +103 to +105
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links point to 'index.html'. If these links are intended to navigate to different pages, ensure the 'href' attributes are updated accordingly.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute for this navigation link is set to 'index.html'. Ensure this is the correct link for the 'Video' section. If not, update it to the correct URL.

>
Video
</a>
</li>
</ul>
</nav>
</header>

<main class="catalog">
<div
class="card"
data-qa="card"
>
<p class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>

<p class="card__product-code">Product code: 195434</p>

<div class="card__reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<p class="card__reviews-counter">Reviews: 5</p>
</div>

<div class="card__price">
<p class="card__price-text">Price:</p>
<p class="card__price-amount">$2,199</p>
</div>

<a
href="#"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute for the 'Buy' button is set to '#'. Ensure this is the correct link for the purchase action. If not, update it to the correct URL.

class="card__button"
Comment on lines +142 to +144
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute of the 'Buy' button is set to '#', which means it doesn't lead anywhere. Consider updating this to point to a relevant page or action.

data-qa="card-hover"
>
Buy
</a>
</div>

<div class="card">
<p class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>

<p class="card__product-code">Product code: 195434</p>

<div class="card__reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<p class="card__reviews-counter">Reviews: 5</p>
</div>

<div class="card__price">
<p class="card__price-text">Price:</p>
<p class="card__price-amount">$2,199</p>
</div>

<a
href="#"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute for the 'Buy' button is set to '#'. Ensure this is the correct link for the purchase action. If not, update it to the correct URL.

class="card__button"
Comment on lines +175 to +177
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute of the 'Buy' button is set to '#', which means it doesn't lead anywhere. Consider updating this to point to a relevant page or action.

>
Buy
</a>
</div>

<div class="card">
<p class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>

<p class="card__product-code">Product code: 195434</p>

<div class="card__reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<p class="card__reviews-counter">Reviews: 5</p>
</div>

<div class="card__price">
<p class="card__price-text">Price:</p>
<p class="card__price-amount">$2,199</p>
</div>

<a
href="#"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute for the 'Buy' button is set to '#'. Ensure this is the correct link for the purchase action. If not, update it to the correct URL.

class="card__button"
Comment on lines +207 to +209
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute of the 'Buy' button is set to '#', which means it doesn't lead anywhere. Consider updating this to point to a relevant page or action.

>
Buy
</a>
</div>

<div class="card">
<p class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>

<p class="card__product-code">Product code: 195434</p>

<div class="card__reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<p class="card__reviews-counter">Reviews: 5</p>
</div>

<div class="card__price">
<p class="card__price-text">Price:</p>
<p class="card__price-amount">$2,199</p>
</div>

<a
href="#"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute for the 'Buy' button is set to '#'. Ensure this is the correct link for the purchase action. If not, update it to the correct URL.

class="card__button"
Comment on lines +239 to +241
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute of the 'Buy' button is set to '#', which means it doesn't lead anywhere. Consider updating this to point to a relevant page or action.

>
Buy
</a>
</div>

<div class="card">
<p class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>

<p class="card__product-code">Product code: 195434</p>

<div class="card__reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<p class="card__reviews-counter">Reviews: 5</p>
</div>

<div class="card__price">
<p class="card__price-text">Price:</p>
<p class="card__price-amount">$2,199</p>
</div>

<a
href="#"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute for the 'Buy' button is set to '#'. Ensure this is the correct link for the purchase action. If not, update it to the correct URL.

class="card__button"
Comment on lines +271 to +273
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute of the 'Buy' button is set to '#', which means it doesn't lead anywhere. Consider updating this to point to a relevant page or action.

>
Buy
</a>
</div>

<div class="card">
<p class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>

<p class="card__product-code">Product code: 195434</p>

<div class="card__reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<p class="card__reviews-counter">Reviews: 5</p>
</div>

<div class="card__price">
<p class="card__price-text">Price:</p>
<p class="card__price-amount">$2,199</p>
</div>

<a
href="#"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute for the 'Buy' button is set to '#'. Ensure this is the correct link for the purchase action. If not, update it to the correct URL.

class="card__button"
Comment on lines +303 to +305
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute of the 'Buy' button is set to '#', which means it doesn't lead anywhere. Consider updating this to point to a relevant page or action.

>
Buy
</a>
</div>

<div class="card">
<p class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>

<p class="card__product-code">Product code: 195434</p>

<div class="card__reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<p class="card__reviews-counter">Reviews: 5</p>
</div>

<div class="card__price">
<p class="card__price-text">Price:</p>
<p class="card__price-amount">$2,199</p>
</div>

<a
href="#"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute for the 'Buy' button is set to '#'. Ensure this is the correct link for the purchase action. If not, update it to the correct URL.

class="card__button"
Comment on lines +335 to +337
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute of the 'Buy' button is set to '#', which means it doesn't lead anywhere. Consider updating this to point to a relevant page or action.

>
Buy
</a>
</div>

<div class="card">
<p class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>

<p class="card__product-code">Product code: 195434</p>

<div class="card__reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<p class="card__reviews-counter">Reviews: 5</p>
</div>

<div class="card__price">
<p class="card__price-text">Price:</p>
<p class="card__price-amount">$2,199</p>
</div>

<a
href="#"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute for the 'Buy' button is set to '#'. Ensure this is the correct link for the purchase action. If not, update it to the correct URL.

class="card__button"
Comment on lines +367 to +369
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'href' attribute of the 'Buy' button is set to '#', which means it doesn't lead anywhere. Consider updating this to point to a relevant page or action.

>
Buy
</a>
</div>
</main>
</body>
</html>
Loading
Loading