Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #4838

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Develop #4838

wants to merge 4 commits into from

Conversation

lucashel-design
Copy link

Checklist

❗️ Replace <your_account> with your GitHub username and copy the links to the Pull Request description:

❗️ Copy this Checklist to the Pull Request description after links, and put - [x] before each point after you checked it.

  • All components follow BEM and use SCSS
  • Repeated sizes and special colors are put to variables
  • Grid is used for the columns
  • Cards are shown in 1, 2, 3, or 4 columns based on screen resolution
  • All changes on :hover are smooth
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Thank you for your hard work on this project! 😊 While your code meets many of the task requirements, there are a few critical issues that need to be addressed before we can approve the pull request:

  1. BEM Naming Conventions: Ensure all elements and modifiers are correctly named according to BEM principles. This will help maintain consistency and readability across your codebase.

  2. Hover Effects: Verify that all specified elements have the correct transition properties to ensure smooth hover effects.

  3. href Attributes: The href attributes are currently placeholders ('#'). Please provide meaningful URLs or handle the click events with JavaScript if these are meant to be dynamic links.

  4. Border-Radius and Layout: Consider adjusting the border-radius value for better visibility and ensure that layout shifts caused by hover effects are managed to prevent overflow or unexpected shifts.

  5. CSS Variables: While your variables.scss file is well-organized, consider using CSS custom properties for colors and sizes throughout your styles for better maintainability.

Addressing these issues will enhance the functionality and maintainability of your code. Keep up the great work, and feel free to reach out if you have any questions! 🌟

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

class="logo"
>
<img
src="./images/logo.png"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alt attribute for the logo image is currently set to 'Moyo logo'. Consider providing a more descriptive text that conveys the purpose of the image, especially if it's used as a link.

<ul class="nav__list">
<li class="nav__item">
<a
href="#"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to '#', which is a placeholder. Consider providing a meaningful URL or using JavaScript to handle the click event if this is meant to be a dynamic link.

>
<div class="card__image">
<a
href="#"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to '#', which is a placeholder. Consider providing a meaningful URL or using JavaScript to handle the click event if this is meant to be a dynamic link.

<div class="button">
<a
class="button__buy"
href="#"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to '#', which is a placeholder. Consider providing a meaningful URL or using JavaScript to handle the click event if this is meant to be a dynamic link.

.cards-container {
box-sizing: border-box;

--column-count: 1;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using CSS custom properties (variables) for colors and sizes throughout your styles to maintain consistency and make future changes easier.

margin-right: 4px;
}

&--4 .stars__star:nth-child(-n + 4) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selector .stars__star:nth-child(-n + 4) is specific to a 4-star rating. Ensure that this logic is flexible enough to accommodate different star ratings if needed.

@@ -0,0 +1,238 @@
.cards-container {
box-sizing: border-box;
--column-count: 1;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using CSS custom properties (variables) for colors and sizes throughout your styles to maintain consistency and make future changes easier.

}

.header {
width: 100vw;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 100vw for width can cause horizontal scrolling issues due to the scrollbar width. Consider using 100% instead to avoid this potential issue.


.stars {
display: flex;
border-radius: 0.5px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The border-radius value of 0.5px is quite small and might not be noticeable. Consider using a larger value if you want the rounded corners to be more visible.

body {
margin: 0;
padding: 0;

font-family: $font-family;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the variable $font-family is defined in the variables file being imported. This will prevent any potential issues with undefined variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants