Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #4843

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #4843

wants to merge 2 commits into from

Conversation

Olifan
Copy link

@Olifan Olifan commented Nov 12, 2024

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Thank you for your hard work on this project! 😊 While your submission meets many of the requirements, there is a critical issue that needs to be addressed before we can approve it. The data-qa attribute for the "Buy" link inside the first card should be corrected from data-qa="hover" to data-qa="card-hover". This is important to ensure the functionality aligns with the task requirements. Once this is fixed, your code will be in great shape! Keep up the great work, and I look forward to seeing the updated version. 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

src/index.html Outdated
</div>

<a
href="https://mate-academy.github.io/layout_task-guideline/"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the link provided in the href attribute is correct and accessible. If this is a placeholder, consider updating it to a valid URL.

src/index.html Outdated
</div>

<a
href="https://mate-academy.github.io/layout_task-guideline/"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute contains a link that should be verified for correctness and accessibility. If it's a placeholder, replace it with a valid URL.

src/index.html Outdated
</div>

<a
href="https://mate-academy.github.io/layout_task-guideline/"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the href attribute for a valid URL. If this is a placeholder, update it to a correct link.

src/index.html Outdated
</div>

<a
href="https://mate-academy.github.io/layout_task-guideline/"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the href attribute contains a valid URL. If this is a placeholder, replace it with a correct link.

src/index.html Outdated
</div>

<a
href="https://mate-academy.github.io/layout_task-guideline/"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify that the href attribute contains a valid URL. If this is a placeholder, update it to a correct link.

src/index.html Outdated
</div>

<a
href="https://mate-academy.github.io/layout_task-guideline/"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify that the href attribute contains a valid URL. If this is a placeholder, update it to a correct link.

background-color: $white;
font-family: $font-family;
text-align: center;
transition: $transition-duration;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transition property should specify which CSS properties the transition effect is applied to. Consider adding a property like transform to the transition declaration.


&:hover {
transform: scale(1.2);
transition: $transition-duration;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transition property should specify which CSS properties the transition effect is applied to. Consider adding a property like transform to the transition declaration.

border-radius: 5px;
margin: 16px;
cursor: pointer;
transition: background-color $transition-duration;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transition property should specify which CSS properties the transition effect is applied to. Consider adding a property like background-color to the transition declaration.

&:hover {
background-color: $white;
box-sizing: border-box;
color: $blue-accent;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The color property here should be applied to the .card__button-text class inside the hover state to ensure the text color changes as expected.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on addressing the previous issue with the data-qa attribute for the "Buy" link inside the first card! 🎉 Your code now meets the task requirements and constraints as specified. While there was a critical issue with the data-qa attribute, you've successfully corrected it, ensuring the implementation aligns with the task description.

Here's a summary of the review:

  • HTML File: Initially, there was a critical issue with the data-qa attribute for the 'Buy' link inside the first card. It needed to be corrected to data-qa="card-hover". You've addressed this, and the HTML is now well-structured and follows the requirements.

  • SCSS Files: All SCSS files, including those for the card component, grid layout, header, navigation, stars, and variables, are well-structured and utilize variables effectively. They ensure responsiveness, consistency, and maintainability across the project. No critical issues were found in these files.

  • Main SCSS File: Properly imports all necessary partials and sets global styles. Consistency is maintained through the use of variables.

Your attention to detail and commitment to aligning with the task requirements is commendable. Keep up the great work! 🚀

Remember, addressing critical issues promptly is essential for the functionality of your code. Continue to review feedback and learn from any mistakes to enhance your coding skills. Happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +110 to +113
<a
href="https://www.moyo.ua/ua/"
class="card__button"
data-qa="card-hover"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data-qa attribute for the 'Buy' link inside the first card should be corrected from data-qa="hover" to data-qa="card-hover" to align with the task requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants