Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add catalog moyo #4847

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add catalog moyo #4847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6add155
add catalog moyo
azhadko98 Nov 13, 2024
48494a0
add update moyo catalog
azhadko98 Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ Create an HTML page with a catalog. Develop semantic page structure as shown on
- remove old `data-qa` attributes
- add `data-qa="nav-hover"` (not just `hover`) to the 4th nav link for testing (`Laptops & computers`)
- add `data-qa="card"` to the first card
- add `data-qa="card-hover"` (not just `hover`) to the link `Buy` inside the first card
- add `data-qa="card-hover"` (not just `hover`) to the link `Buy` inside azhadko98
- nav links color is not `black` anymore (nav links should have `#060b35` color)
- add the class `is-active` to the first link (`Apple`) in the navigation
- use `<main>` tag for cards container
- use `<main>` tag for cards container
- use the grid for cards with different numbers of columns:
- 1 for the smaller screens
- 2 starting at `488px`
Expand All @@ -33,8 +33,8 @@ This is possible because [we use the Parcel library](https://en.parceljs.org/scs
## Checklist

❗️ Replace `<your_account>` with your GitHub username and copy the links to the `Pull Request` description:
- [DEMO LINK](https://<your_account>.github.io/layout_catalog/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_catalog/report/html_report/)
- [DEMO LINK](https://azhadko98.github.io/layout_catalog/)
- [TEST REPORT LINK](https://azhadko98.github.io/layout_catalog/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
342 changes: 340 additions & 2 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,345 @@
/>
</head>

<body>
<h1>Catalog</h1>
<body class="body">
<header class="header">
<img
src="images/logo.png"
alt="Логотип"
class="logo_img"
/>
<nav class="nav">
<ul class="nav__list">
<li class="nav__item">
<a
class="nav__link is-active"
href="./src"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links have the same href attribute './src'. Ensure that each link points to the correct destination page.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links have the same href attribute ('./src'). Please update these links to point to the correct destination pages to ensure proper navigation functionality.

>
APPLE
</a>
</li>
<li class="nav__item">
<a
class="nav__link"
href="./src"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links have the same href attribute './src'. Ensure that each link points to the correct destination page.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links have the same href attribute ('./src'). Please update these links to point to the correct destination pages to ensure proper navigation functionality.

>
SAMSUNG
</a>
</li>
<li class="nav__item">
<a
class="nav__link"
href="./src"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links have the same href attribute './src'. Ensure that each link points to the correct destination page.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links have the same href attribute ('./src'). Please update these links to point to the correct destination pages to ensure proper navigation functionality.

>
SMARTPHONES
</a>
</li>
<li class="nav__item">
<a
class="nav__link"
href="./src"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links have the same href attribute './src'. Ensure that each link points to the correct destination page.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links have the same href attribute ('./src'). Please update these links to point to the correct destination pages to ensure proper navigation functionality.

data-qa="nav-hover"
>
LAPTOPS & COMPUTERS
</a>
</li>
<li class="nav__item">
<a
class="nav__link"
href="./src"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links have the same href attribute './src'. Ensure that each link points to the correct destination page.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links have the same href attribute ('./src'). Please update these links to point to the correct destination pages to ensure proper navigation functionality.

>
GADGETS
</a>
</li>
<li class="nav__item">
<a
class="nav__link"
href="./src"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links have the same href attribute './src'. Ensure that each link points to the correct destination page.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links have the same href attribute ('./src'). Please update these links to point to the correct destination pages to ensure proper navigation functionality.

>
TABLETS
</a>
</li>
<li class="nav__item">
<a
class="nav__link"
href="./src"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links have the same href attribute './src'. Ensure that each link points to the correct destination page.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links have the same href attribute ('./src'). Please update these links to point to the correct destination pages to ensure proper navigation functionality.

>
PHOTO
</a>
</li>
<li class="nav__item">
<a
class="nav__link"
href="./src"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links have the same href attribute './src'. Ensure that each link points to the correct destination page.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All navigation links have the same href attribute ('./src'). Please update these links to point to the correct destination pages to ensure proper navigation functionality.

>
VIDEO
</a>
</li>
</ul>
</nav>
</header>
<main class="main">
<div class="main__container">
<div
class="card"
data-qa="card"
>
<img
src="../src/images/imac.jpeg"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image source for all product cards is the same ('../src/images/imac.jpeg'). If this is not intentional, ensure each card has the correct image source.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All product cards currently use the same image source ('../src/images/imac.jpeg'). If this is not intentional, please ensure each card has the correct image source to display the intended product images.

alt="computer"
class="card__foto"
/>
<p class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>
<p class="card__product-code">Product code: 195434</p>
<div class="card__stars">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__name-price">Price:</p>
<p class="card__num-price">$2,199</p>
</div>
<button
class="card__button"
data-qa="card-hover"
type="button"
>
Buy
</button>
</div>
<div class="card">
<img
src="../src/images/imac.jpeg"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image source for all product cards is the same ('../src/images/imac.jpeg'). If this is not intentional, ensure each card has the correct image source.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All product cards currently use the same image source ('../src/images/imac.jpeg'). If this is not intentional, please ensure each card has the correct image source to display the intended product images.

alt="computer"
class="card__foto"
/>
<p class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>
<p class="card__product-code">Product code: 195434</p>
<div class="card__stars">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__name-price">Price:</p>
<p class="card__num-price">$2,199</p>
</div>
<button
class="card__button"
data-qa="card-hover"
type="button"
>
Buy
</button>
</div>
<div class="card">
<img
src="../src/images/imac.jpeg"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image source for all product cards is the same ('../src/images/imac.jpeg'). If this is not intentional, ensure each card has the correct image source.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All product cards currently use the same image source ('../src/images/imac.jpeg'). If this is not intentional, please ensure each card has the correct image source to display the intended product images.

alt="computer"
class="card__foto"
/>
<p class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>
<p class="card__product-code">Product code: 195434</p>
<div class="card__stars">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__name-price">Price:</p>
<p class="card__num-price">$2,199</p>
</div>
<button
class="card__button"
data-qa="card-hover"
type="button"
>
Buy
</button>
</div>
<div class="card">
<img
src="../src/images/imac.jpeg"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image source for all product cards is the same ('../src/images/imac.jpeg'). If this is not intentional, ensure each card has the correct image source.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All product cards currently use the same image source ('../src/images/imac.jpeg'). If this is not intentional, please ensure each card has the correct image source to display the intended product images.

alt="computer"
class="card__foto"
/>
<p class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>
<p class="card__product-code">Product code: 195434</p>
<div class="card__stars">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__name-price">Price:</p>
<p class="card__num-price">$2,199</p>
</div>
<button
class="card__button"
data-qa="card-hover"
type="button"
>
Buy
</button>
</div>
<div class="card">
<img
src="../src/images/imac.jpeg"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image source for all product cards is the same ('../src/images/imac.jpeg'). If this is not intentional, ensure each card has the correct image source.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All product cards currently use the same image source ('../src/images/imac.jpeg'). If this is not intentional, please ensure each card has the correct image source to display the intended product images.

alt="computer"
class="card__foto"
/>
<p class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>
<p class="card__product-code">Product code: 195434</p>
<div class="card__stars">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__name-price">Price:</p>
<p class="card__num-price">$2,199</p>
</div>
<button
class="card__button"
data-qa="card-hover"
type="button"
>
Buy
</button>
</div>
<div class="card">
<img
src="../src/images/imac.jpeg"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image source for all product cards is the same ('../src/images/imac.jpeg'). If this is not intentional, ensure each card has the correct image source.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All product cards currently use the same image source ('../src/images/imac.jpeg'). If this is not intentional, please ensure each card has the correct image source to display the intended product images.

alt="computer"
class="card__foto"
/>
<p class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>
<p class="card__product-code">Product code: 195434</p>
<div class="card__stars">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__name-price">Price:</p>
<p class="card__num-price">$2,199</p>
</div>
<button
class="card__button"
data-qa="card-hover"
type="button"
>
Buy
</button>
</div>
<div class="card">
<img
src="../src/images/imac.jpeg"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image source for all product cards is the same ('../src/images/imac.jpeg'). If this is not intentional, ensure each card has the correct image source.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All product cards currently use the same image source ('../src/images/imac.jpeg'). If this is not intentional, please ensure each card has the correct image source to display the intended product images.

alt="computer"
class="card__foto"
/>
<p class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>
<p class="card__product-code">Product code: 195434</p>
<div class="card__stars">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__name-price">Price:</p>
<p class="card__num-price">$2,199</p>
</div>
<button
class="card__button"
data-qa="card-hover"
type="button"
>
Buy
</button>
</div>
<div class="card">
<img
src="../src/images/imac.jpeg"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image source for all product cards is the same ('../src/images/imac.jpeg'). If this is not intentional, ensure each card has the correct image source.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All product cards currently use the same image source ('../src/images/imac.jpeg'). If this is not intentional, please ensure each card has the correct image source to display the intended product images.

alt="computer"
class="card__foto"
/>
<p class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>
<p class="card__product-code">Product code: 195434</p>
<div class="card__stars">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__name-price">Price:</p>
<p class="card__num-price">$2,199</p>
</div>
<button
class="card__button"
data-qa="card-hover"
type="button"
>
Buy
</button>
</div>
</div>
</main>
</body>
</html>
9 changes: 9 additions & 0 deletions src/styles/body.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
.body {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selector '.body' is targeting a class named 'body'. If you intend to style the HTML body element, use 'body' instead of '.body'.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .body class is used instead of the body element selector. If you intend to style the HTML body element, please correct this to ensure styles are applied as intended.

margin: 0;
font-family: Roboto, sans-serif;
font-weight: 400;
font-size: 10px;
line-height: 14px;
color: #060b35;
box-sizing: border-box;
}
Loading
Loading