Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #4849

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Develop #4849

wants to merge 2 commits into from

Conversation

lopatkinss
Copy link

❗️ Copy this Checklist to the Pull Request description after links, and put - [x] before each point after you checked it.

  • All components follow BEM and use SCSS
  • Repeated sizes and special colors are put to variables
  • Grid is used for the columns
  • Cards are shown in 1, 2, 3, or 4 columns based on screen resolution
  • All changes on :hover are smooth
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great effort on your submission! 🎉 Your code demonstrates a solid understanding of SCSS and HTML structuring, with well-organized components and effective use of CSS techniques like BEM, Grid, and Flexbox. However, there are a few areas that need attention:

  1. HTML Structure: Ensure the <main> tag is used for the cards container instead of a <section> tag.

  2. Data Attributes: Correct the data-qa attributes for the "Buy" button and the 4th nav link to match the requirements.

  3. Grid Layout: Implement media queries to adjust the grid layout for different screen sizes.

  4. Hover Effects: Add a smooth hover effect to increase the card size by 20% without affecting neighboring cards.

  5. CSS Variables: Use variables for repeated sizes and special colors to enhance maintainability.

  6. SCSS and BEM: Double-check your BEM conventions and SCSS usage to ensure they align with the guidelines.

These improvements are crucial for meeting the task requirements and enhancing the functionality and maintainability of your code. Remember, addressing these issues will help you grow as a developer. Keep up the good work, and continue learning from each experience! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants