made catalog #4850
made catalog #4850
Conversation
There was a problem hiding this comment.
It looks like there are a few critical issues that need to be addressed before we can approve your pull request. The repeated use of href="#" is a significant concern as it affects the navigation functionality. This needs to be replaced with valid URLs or handled with JavaScript to ensure proper navigation. Additionally, please ensure that all necessary images and SCSS modules are present in the specified directories to avoid missing styles or assets. Once these issues are resolved, your code will be in great shape! Keep up the good work and don't hesitate to reach out if you need any help. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: 7]
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Thank you for your submission! 🎉 Your code has been reviewed and is approved to help you progress in your learning journey. However, there are a few important issues that need attention:
-
Navigation Links: The use of
href="#"in navigation links can lead to unexpected behavior. Please replace these with valid URLs or handle them with JavaScript to ensure proper navigation. -
HTML Structure: There's a misplaced
hrefattribute within alielement. Make sure it is correctly placed inside anatag to function properly as a link. -
SCSS and BEM: Ensure that all components consistently use BEM naming conventions as required by the task.
-
Data Attributes: Verify that the
data-qaattributes are correctly applied, especially thedata-qa="nav-hover"on the 4th nav link. -
Grid Layout: Confirm that the grid layout is responsive and adapts to different screen resolutions as intended.
-
Resource Verification: Double-check that all paths to imported modules, font files, and images are correct and that these resources exist in the specified directories.
These improvements are crucial for the functionality and accessibility of your project. Keep up the great work, and use this feedback to enhance your skills! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <li | ||
| class="header__link" | ||
| data-qa="nav-hover" | ||
| href="/laptop-Computers" |
There was a problem hiding this comment.
The href attribute is incorrectly placed within the li element. It should be inside the a tag to function properly as a link.
| <p class="right">$2,199</p> | ||
| </div> | ||
| <a | ||
| href="#" |
There was a problem hiding this comment.
Using href="#" is not recommended as it can cause unexpected behavior. Consider replacing it with a valid URL or handling the click event with JavaScript.
| <p class="right">$2,199</p> | ||
| </div> | ||
| <a | ||
| href="#" |
There was a problem hiding this comment.
Using href="#" is not recommended as it can cause unexpected behavior. Consider replacing it with a valid URL or handling the click event with JavaScript.
| <p class="right">$2,199</p> | ||
| </div> | ||
| <a | ||
| href="#" |
There was a problem hiding this comment.
Using href="#" is not recommended as it can cause unexpected behavior. Consider replacing it with a valid URL or handling the click event with JavaScript.
| <p class="right">$2,199</p> | ||
| </div> | ||
| <a | ||
| href="#" |
There was a problem hiding this comment.
Using href="#" is not recommended as it can cause unexpected behavior. Consider replacing it with a valid URL or handling the click event with JavaScript.
| <p class="right">$2,199</p> | ||
| </div> | ||
| <a | ||
| href="#" |
There was a problem hiding this comment.
Using href="#" is not recommended as it can cause unexpected behavior. Consider replacing it with a valid URL or handling the click event with JavaScript.
| <p class="right">$2,199</p> | ||
| </div> | ||
| <a | ||
| href="#" |
There was a problem hiding this comment.
Using href="#" is not recommended as it can cause unexpected behavior. Consider replacing it with a valid URL or handling the click event with JavaScript.
| <p class="right">$2,199</p> | ||
| </div> | ||
| <a | ||
| href="#" |
There was a problem hiding this comment.
Using href="#" is not recommended as it can cause unexpected behavior. Consider replacing it with a valid URL or handling the click event with JavaScript.
| <p class="right">$2,199</p> | ||
| </div> | ||
| <a | ||
| href="#" |
There was a problem hiding this comment.
Using href="#" is not recommended as it can cause unexpected behavior. Consider replacing it with a valid URL or handling the click event with JavaScript.
:hoverare smooth