Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add solution #4851

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add solution #4851

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c80649b
add solution
lolekmakso Nov 13, 2024
970a2ba
fixed bugs
lolekmakso Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Create an HTML page with a catalog. Develop semantic page structure as shown on
- add `data-qa="card-hover"` (not just `hover`) to the link `Buy` inside the first card
- nav links color is not `black` anymore (nav links should have `#060b35` color)
- add the class `is-active` to the first link (`Apple`) in the navigation
- use `<main>` tag for cards container
- use `<main>` tag for cards container
- use the grid for cards with different numbers of columns:
- 1 for the smaller screens
- 2 starting at `488px`
Expand All @@ -33,14 +33,14 @@ This is possible because [we use the Parcel library](https://en.parceljs.org/scs
## Checklist

❗️ Replace `<your_account>` with your GitHub username and copy the links to the `Pull Request` description:
- [DEMO LINK](https://<your_account>.github.io/layout_catalog/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_catalog/report/html_report/)
- [DEMO LINK](https://lolekmakso.github.io/layout_catalog/)
- [TEST REPORT LINK](https://lolekmakso.github.io/layout_catalog/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

- [ ] All components follow BEM and use SCSS
- [ ] Repeated sizes and special colors are put to variables
- [ ] Grid is used for the columns
- [ ] Cards are shown in 1, 2, 3, or 4 columns based on screen resolution
- [ ] All changes on `:hover` are smooth
- [ ] Code follows all the [Code Style Rules ❗️](https://mate-academy.github.io/layout_task-guideline/html-css-code-style-rules)
- [x] All components follow BEM and use SCSS
- [x] Repeated sizes and special colors are put to variables
- [x] Grid is used for the columns
- [x] Cards are shown in 1, 2, 3, or 4 columns based on screen resolution
- [x] All changes on `:hover` are smooth
- [x] Code follows all the [Code Style Rules ❗️](https://mate-academy.github.io/layout_task-guideline/html-css-code-style-rules)
315 changes: 314 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,319 @@
</head>

<body>
<h1>Catalog</h1>
<header class="header">
<a
href="#"
class="logo"
>
<img
src="./images/logo.png"
alt="Moyo Logo"
/>
</a>
<nav class="nav">
<ul class="nav__list">
<li class="nav__item">
<a
href="#"
class="is-active nav__link"
>
Apple
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
Samsung
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
Smartphones
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
data-qa="nav-hover"
>
Laptops & Computers
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
Gadgets
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
Tablets
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
Photo
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
Video
</a>
</li>
</ul>
</nav>
</header>
<main class="container">
<article
class="card"
data-qa="card"
>
<img
class="card__img"
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27 Retina"
/>
<div class="card__description">
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<p class="card__code">Product code: 195434</p>
</div>
<div class="card__reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews-count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-text">Price:</p>
<p class="card__dollar">$2,199</p>
</div>
<button
class="card__button"
data-qa="card-hover"
>
Buy
</button>
</article>
<article class="card">
<img
class="card__img"
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27 Retina"
/>
<div class="card__description">
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<p class="card__code">Product code: 195434</p>
</div>
<div class="card__reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews-count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-text">Price:</p>
<p class="card__dollar">$2,199</p>
</div>
<button class="card__button">Buy</button>
</article>
<article class="card">
<img
class="card__img"
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27 Retina"
/>
<div class="card__description">
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<p class="card__code">Product code: 195434</p>
</div>
<div class="card__reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews-count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-text">Price:</p>
<p class="card__dollar">$2,199</p>
</div>
<button class="card__button">Buy</button>
</article>
<article class="card">
<img
class="card__img"
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27 Retina"
/>
<div class="card__description">
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<p class="card__code">Product code: 195434</p>
</div>
<div class="card__reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews-count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-text">Price:</p>
<p class="card__dollar">$2,199</p>
</div>
<button class="card__button">Buy</button>
</article>
<article class="card">
<img
class="card__img"
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27 Retina"
/>
<div class="card__description">
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<p class="card__code">Product code: 195434</p>
</div>
<div class="card__reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews-count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-text">Price:</p>
<p class="card__dollar">$2,199</p>
</div>
<button class="card__button">Buy</button>
</article>
<article class="card">
<img
class="card__img"
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27 Retina"
/>
<div class="card__description">
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<p class="card__code">Product code: 195434</p>
</div>
<div class="card__reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews-count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-text">Price:</p>
<p class="card__dollar">$2,199</p>
</div>
<button class="card__button">Buy</button>
</article>
<article class="card">
<img
class="card__img"
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27 Retina"
/>
<div class="card__description">
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<p class="card__code">Product code: 195434</p>
</div>
<div class="card__reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews-count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-text">Price:</p>
<p class="card__dollar">$2,199</p>
</div>
<button class="card__button">Buy</button>
</article>
<article class="card">
<img
class="card__img"
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27 Retina"
/>
<div class="card__description">
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<p class="card__code">Product code: 195434</p>
</div>
<div class="card__reviews">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews-count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-text">Price:</p>
<p class="card__dollar">$2,199</p>
</div>
<button class="card__button">Buy</button>
Comment on lines +106 to +336
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The product cards are repeated with the same content. To improve maintainability, consider using a templating engine or JavaScript to dynamically generate these cards. This will make your code easier to update and manage.

</article>
Comment on lines +142 to +337
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The product cards are repeated multiple times with the same content. This repetition can be optimized by using a templating engine or JavaScript to dynamically generate these cards. This will make the code more maintainable and easier to update.

</main>
</body>
</html>
Loading
Loading