Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first solution #4853

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Vitalii120296
Copy link

  • DEMO LINK
  • TEST REPORT LINK
  • All components follow BEM and use SCSS
  • Repeated sizes and special colors are put to variables
  • Grid is used for the columns
  • Cards are shown in 1, 2, 3, or 4 columns based on screen resolution
  • All changes on :hover are smooth
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Thank you for your hard work on this project! 🌟 While your code meets many of the task requirements, there are a few critical issues that need to be addressed before we can proceed. Here are the main points to focus on:

  1. Mixin and Variable Definitions: Ensure that the mixin stars and variables like $imageWidth and $imageHeight are defined or imported correctly to avoid compilation errors.

  2. Variable Typos: Correct the typos in variable names such as $numberOfRow and $numberOfColums to $numberOfRows and $numberOfColumns respectively, to ensure proper functionality.

  3. Label Association: Make sure that all label elements are correctly associated with their respective input elements using the for attribute. This is crucial for accessibility.

  4. Semantic HTML: Avoid wrapping a form element with a label. Instead, use the for attribute to associate labels with form controls.

Please address these issues to ensure full compliance with the task requirements. Once these changes are made, we can move forward with approval. Keep up the great work, and don't hesitate to reach out if you need any help! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Comment on lines +137 to +138
<label for="buy"
data-qa="card-hover">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label element is used here, but it is not semantically correct to wrap a form element with a label. Instead, the label should be associated with a specific form control using the for attribute.

<div
class="product__button"
>
<label for="buy2">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the label element is correctly associated with the input element using the for attribute. The for attribute should match the id of the input element.

<div
class="product__button"
>
<label for="buy3">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label element should be associated with a specific input element using the for attribute. Ensure that this attribute matches the id of the input element.

<div
class="product__button"
>
<label for="buy4">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the label element is correctly associated with the input element using the for attribute. The for attribute should match the id of the input element.

<div
class="product__button"
>
<label for="buy5">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the label element is correctly associated with the input element using the for attribute. The for attribute should match the id of the input element.

width: 100%;
grid-auto-flow: row;
grid-template-columns: repeat($numberOfColums, 200px);
grid-template-rows: repeat($numberOfRow, 408px);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the variable name $numberOfRow. It should be $numberOfRows to ensure the variable is correctly referenced.

Comment on lines +27 to +28
list-style: none;
list-style-type: none;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list-style and list-style-type properties are redundant. You only need one of them to remove the list style. Consider removing one to clean up the code.

Comment on lines +19 to +21
background-size: $imageWidth $imageHeight;
width: $imageWidth;
height: $imageHeight;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variables $imageWidth and $imageHeight are used here, but they are not defined within this file. Ensure these variables are defined elsewhere or imported correctly to avoid compilation errors.

Comment on lines +39 to +41
&:hover &__name {
color: #34568b;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a transition effect for the color change on hover to make the interaction smoother. You can use transition: color 300ms;.

margin-right: 4px;
}

@include stars($starsAmount);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mixin @include stars($starsAmount); is used here, but it is not defined within this file. Ensure that the mixin stars is defined elsewhere or imported correctly to avoid compilation errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants