Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

solution #243

wants to merge 1 commit into from

Conversation

ArtemZakhar
Copy link

@ArtemZakhar ArtemZakhar commented May 25, 2024

Hi)

I have done it very fast) 🚀 🚀 🚀

Sequelize is amazing!)

Have a nice day) ❤️

Copy link

@DanilWeda DanilWeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.
Approved!
Thanks)

Comment on lines +144 to +146
await sequelize.transaction(async (t) => {
await Expense.update(data, { where: { id } }, { transaction: t });
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
await sequelize.transaction(async (t) => {
await Expense.update(data, { where: { id } }, { transaction: t });
});
await sequelize.transaction(async (transaction) => {
await Expense.update(data, { where: { id } }, { transaction });
});

as alternative without one letter naming

.json({ success: false, error: response[400].messages.noData });
}

const newUser = await updateUser(+id, data);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const newUser = await updateUser(+id, data);
const newUser = await updateUser(Number(id), data);

as alternative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants