solution #260
Open
solution #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanilWeda
suggested changes
Jul 10, 2024
| const { userId, categories, from, to } = req.query; | ||
| const all = await expensesService.getAll(+userId, categories, from, to); | ||
|
|
||
| return res.status(200).send(all); |
There was a problem hiding this comment.
You can move All status to constants
| const get = async (req, res) => { | ||
| try { | ||
| const { userId, categories, from, to } = req.query; | ||
| const all = await expensesService.getAll(+userId, categories, from, to); |
There was a problem hiding this comment.
Suggested change
| const all = await expensesService.getAll(+userId, categories, from, to); | |
| const all = await expensesService.getAll(Number(userId), categories, from, to); |
as alternative
src/routes/expenses.route.js
Outdated
| const expensesRoute = express.Router(); | ||
| const controller = require('../controllers/expenses.controller'); | ||
|
|
||
| expensesRoute.get('/', controller.get); |
There was a problem hiding this comment.
You can move all routes to constants
src/routes/users.route.js
Outdated
|
|
||
| const usersRoute = express.Router(); | ||
|
|
||
| usersRoute.get('/', controller.get); |
DanilWeda
approved these changes
Jul 10, 2024
Comment on lines
+4
to
+8
| const HTTP_OK = 200; | ||
| const HTTP_BAD_REQUEST = 400; | ||
| const HTTP_NOT_FOUND = 404; | ||
| const HTTP_NO_CONTENT = 204; | ||
| const HTTP_CREATED = 201; |
There was a problem hiding this comment.
You can move all constants in separate file ( because you have duplication)
Comment on lines
+3
to
+7
| const HTTP_OK = 200; | ||
| const HTTP_BAD_REQUEST = 400; | ||
| const HTTP_NOT_FOUND = 404; | ||
| const HTTP_NO_CONTENT = 204; | ||
| const HTTP_CREATED = 201; |
There was a problem hiding this comment.
You can move all constants in separate file ( because you have duplication)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.