Develop #269
Open
Develop #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanyaBratashchuk
suggested changes
Jul 11, 2024
Comment on lines
29
to
55
| let filteredExpenses = expenses; | ||
|
|
||
| if (userId !== null) { | ||
| filteredExpenses = filteredExpenses.filter( | ||
| (expense) => expense.userId === userId, | ||
| ); | ||
| } | ||
|
|
||
| if (from && to) { | ||
| filteredExpenses = filteredExpenses.filter((expense) => { | ||
| const spentAt = new Date(expense.spentAt); | ||
|
|
||
| return spentAt >= from && spentAt <= to; | ||
| }); | ||
| } | ||
|
|
||
| if (categories.length > 0) { | ||
| filteredExpenses = filteredExpenses.reduce((acc, expense) => { | ||
| if (categories.includes(expense.category)) { | ||
| acc.push(expense); | ||
| } | ||
|
|
||
| return acc; | ||
| }, []); | ||
| } | ||
|
|
||
| return filteredExpenses; |
There was a problem hiding this comment.
Controllers are just the entry point for requests and are responsible for sending back the response to the client. Services, on the other hand, contain the business logic. So move business logic to services
Comment on lines
+5
to
+7
| const normalize = ({ id, name }) => { | ||
| return { id, name }; | ||
| }; |
There was a problem hiding this comment.
why do you need this function
There was a problem hiding this comment.
to not return to client other fields like created_at, as was suggested in video lesson
SanyaBratashchuk
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.