finished task #218
Open
finished task #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And678
suggested changes
Aug 12, 2023
src/targetNumber.js
Outdated
Comment on lines
3
to
4
| const targetNumber = Math.round(Math.random() * 9000 + 999).toString(); | ||
|
|
src/targetNumber.js
Outdated
|
|
||
| const targetNumber = Math.round(Math.random() * 9000 + 999).toString(); | ||
|
|
||
| module.exports = { targetNumber }; |
There was a problem hiding this comment.
Better export a function to generate a number, not the number itself, as per requirements:
Please create separate modules for generating a number...
src/terminal.js
Outdated
Comment on lines
9
to
13
| return new Promise((resolve) => { | ||
| terminal.question('Please enter your guess numeber: ', (number) => { | ||
| return resolve(number); | ||
| }); | ||
| }); |
src/app.js
Outdated
| const [bulls, cows] = checkBullsAndCows(targetNumber, userNumber); | ||
|
|
||
| terminal.write( | ||
| `\nNumber of bulls - ${bulls}, number of cows - ${cows} ${targetNumber}\n` |
There was a problem hiding this comment.
Not fun this way. ;)
Suggested change
| `\nNumber of bulls - ${bulls}, number of cows - ${cows} ${targetNumber}\n` | |
| `\nNumber of bulls - ${bulls}, number of cows - ${cows}\n` |
And678
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.