Develop #225
Develop #225
Conversation
src/app.js
Outdated
| terminalInput.close(); | ||
| } else { | ||
| terminalInput.write(' '); | ||
| terminalInput.write(checkedNumberFromRandom.join(' ')); |
There was a problem hiding this comment.
Consider adding a newline character at the end of the printed number for better readability in the terminal.
| const checkedBull = checkedNumberFromRandom.filter(item => item === 'bull'); | ||
|
|
||
| if (checkedBull.length === 4) { | ||
| terminalInput.write('You win'); |
There was a problem hiding this comment.
Consider adding a newline character at the end of the win message for better readability in the terminal.
| let checkedValue = false; | ||
| const randomNum = Math.ceil(Math.random() * 10000); | ||
|
|
||
| for (let i = 0; i < randomNum.length; i++) { |
There was a problem hiding this comment.
randomNum is a number, not a string. You cannot use .length property or indexing on a number. Convert randomNum to a string before this line.
src/random.js
Outdated
|
|
||
| for (let i = 0; i < randomNum.length; i++) { | ||
| for (let q = 0; q < randomNum.length; q++) { | ||
| if (randomNum[i] === randomNum[q]) { |
There was a problem hiding this comment.
The if condition will always be true when i equals to q. You need to exclude the case when i equals to q.
src/random.js
Outdated
| } | ||
| } | ||
|
|
||
| return checkedValue ? random() : String(randomNum); |
There was a problem hiding this comment.
In case of checkedValue being true, you are calling random() again. This recursion can risk a stack overflow if a number with unique digits is not found in reasonable iterations.
| let checkedValue = false; | ||
| const randomNum = Math.ceil(Math.random() * 10000); | ||
|
|
||
| for (let i = 0; i < randomNum.length; i++) { |
| const checkedNumberFromRandom = checkedNumbers(randomNum, number); | ||
| const checkedBull = checkedNumberFromRandom.filter(item => item === 'bull'); | ||
|
|
||
| if (checkedBull.length === 4) { |
There was a problem hiding this comment.
4 is a 'magic number' so makes sense to move it to the variable
No description provided.